Skip to content

pre-commit hook for formatting JSON files #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kornerc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pre-commit hook for formatting JSON files #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f4c49b
pre-commit pretty-format-json for formating JSON files
kornerc Jan 7, 2026
edff95a
Format JSON files
kornerc Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
15 changes: 15 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,18 @@ repos:
hooks:
- id: markdownlint
args: ["--fix"]
- repo: https://github.com/pre-commit/pre-commit-hooks
Copy link
Member

@mgovers mgovers Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please also add this to the code quality github actions check?

rev: v6.0.0
hooks:
- id: pretty-format-json
args:
- --autofix # automatically format json files
- --indent=2 # 2 spaces for indentation
- --no-sort-keys # when autofixing, retain the original key ordering (instead of sorting the keys)
- --no-ensure-ascii # preserve unicode characters instead of converting to escape sequences
files: >
(?x)^(
# fix JSON formatting in the following top-level folders:
code_generation|
tests
)/.*\.json$
Comment on lines +51 to +65
Copy link
Contributor Author

@kornerc kornerc Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change in this PR which is not coming from the re-formatting.

If you prefer I can also revert the commit which reformats all the JSON files and you can run pre-commit run --all-files pretty-format-json and commit the changes yourself.

Loading
Loading