Skip to content

Remove id for correlation from Exception. #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Remove id for correlation from Exception. #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions shell/agents/Microsoft.Azure.Agent/Telemetry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,25 +143,20 @@ internal static AzTrace Chat(CopilotResponse response)
return null;
}

internal static AzTrace Exception(CopilotResponse response, object details)
internal static AzTrace Exception(object details)
{
if (Telemetry.Enabled)
{
return new()
{
EventType = "Exception",
QueryId = response?.ReplyToId,
TopicName = response?.TopicName,
ConversationId = response?.ConversationId,
EventType = "AIShell Exception",
Details = details
};
}

// Don't create an object when telemetry is disabled.
return null;
}

internal static AzTrace Exception(object details) => Exception(response: null, details);
}

internal class Telemetry
Expand Down