Skip to content

Update OSInfo resource to return _name #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 12, 2025

Conversation

SteveL-MSFT
Copy link
Member

PR Summary

Since we added the ability for resources to return _name, update OSInfo resource to use this as " "

@SteveL-MSFT SteveL-MSFT requested review from Copilot and tgauth August 8, 2025 19:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the OSInfo resource to implement the _name field functionality, which returns a formatted string combining the operating system family, version, and architecture. This enhances resource identification by providing a human-readable name in the format " ".

  • Adds a name field to the OsInfo struct that serializes as _name
  • Implements name generation logic combining family, version, and architecture
  • Adds test coverage to verify the name field format

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
osinfo/src/config.rs Adds name field to OsInfo struct and implements name generation logic
osinfo/tests/osinfo.tests.ps1 Adds test to verify the name field contains the expected format

Steve Lee (POWERSHELL HE/HIM) (from Dev Box) added 2 commits August 12, 2025 07:24
@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Aug 12, 2025
Merged via the queue into PowerShell:main with commit 7a0bda5 Aug 12, 2025
4 checks passed
@SteveL-MSFT SteveL-MSFT deleted the osinfo-export-name branch August 12, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants