-
Notifications
You must be signed in to change notification settings - Fork 48
Add Bicep example #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Bicep example #806
Conversation
I'm going to hold off on adding Bicep examples until we make more progress on our Bicep extension and also a DSC extension for Bicep. |
With the Bicep extension merged and a request from Jason on #973, I made a slight rename, including a condition. Can you check once again @SteveL-MSFT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that uses this file to ensure we don't accidentally break it in the future?
Merged with the latest changes as requested @SteveL-MSFT. Should be good to go :) |
properties: { | ||
Ensure: 'Present' | ||
Type: 'File' | ||
DestinationPath: 'C:\\DSC\\config.txt' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of hardcoding C:
, you should use the systemRoot()
function to get the drive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only if that was possible. I have created an issue on Bicep repository. Do you mind pulling in the example for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Steve's comments - LGTM
PR Summary
This PR adds a simple Bicep example