Skip to content

Add Bicep example #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Add Bicep example #806

wants to merge 22 commits into from

Conversation

Gijsreyn
Copy link
Contributor

PR Summary

This PR adds a simple Bicep example

@Gijsreyn Gijsreyn marked this pull request as ready for review May 10, 2025 06:33
@SteveL-MSFT
Copy link
Member

I'm going to hold off on adding Bicep examples until we make more progress on our Bicep extension and also a DSC extension for Bicep.

@SteveL-MSFT SteveL-MSFT marked this pull request as draft May 20, 2025 22:15
@Gijsreyn Gijsreyn marked this pull request as ready for review July 29, 2025 00:59
@Gijsreyn
Copy link
Contributor Author

With the Bicep extension merged and a request from Jason on #973, I made a slight rename, including a condition. Can you check once again @SteveL-MSFT?

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that uses this file to ensure we don't accidentally break it in the future?

@Gijsreyn Gijsreyn requested a review from SteveL-MSFT July 30, 2025 00:21
@Gijsreyn
Copy link
Contributor Author

Gijsreyn commented Aug 8, 2025

Merged with the latest changes as requested @SteveL-MSFT. Should be good to go :)

properties: {
Ensure: 'Present'
Type: 'File'
DestinationPath: 'C:\\DSC\\config.txt'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hardcoding C:, you should use the systemRoot() function to get the drive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if that was possible. I have created an issue on Bicep repository. Do you mind pulling in the example for now?

Copy link
Collaborator

@theJasonHelmick theJasonHelmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Steve's comments - LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants