add comment indicating the 'IsLatestVersion eq true' solution applies to JFrog but may also apply to other PMPs

anamnavi · anamnavi · commit 4aa8f3382d2c · 2025-01-07T12:50:31.000-05:00
diff --git a/src/code/V2ServerAPICalls.cs b/src/code/V2ServerAPICalls.cs
@@ -918,8 +918,10 @@ private string FindAllFromTypeEndPoint(bool includePrerelease, bool isSearchingM
 
                 if (includePrerelease) {
                     queryBuilder.AdditionalParameters["includePrerelease"] = "true";
+                    // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsAbsoluteLatestVersion correctly
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");
                 } else {
+                    // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsLatestVersion correctly
                     filterBuilder.AddCriterion("IsLatestVersion eq true");
                 }
             }
@@ -965,6 +967,7 @@ private string FindTagFromEndpoint(string[] tags, bool includePrerelease, bool i
             if (includePrerelease) {
                 queryBuilder.AdditionalParameters["includePrerelease"] = "true";
                 if (_isJFrogRepo) {
+                    // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsAbsoluteLatestVersion correctly
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");
                 }
                 else {
@@ -1014,6 +1017,7 @@ private string FindCommandOrDscResource(string[] tags, bool includePrerelease, b
             if (includePrerelease) {
                 queryBuilder.AdditionalParameters["includePrerelease"] = "true";
                 if (_isJFrogRepo) {
+                    // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsAbsoluteLatestVersion correctly
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");
                 }
                 else {
@@ -1022,6 +1026,7 @@ private string FindCommandOrDscResource(string[] tags, bool includePrerelease, b
                 }
             } else {
                 if (_isJFrogRepo) {
+                    // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsLatestVersion correctly
                     filterBuilder.AddCriterion("IsLatestVersion eq true");
                 }
                 else {
@@ -1067,6 +1072,7 @@ private string FindNameGlobbing(string packageName, ResourceType type, bool incl
             if (includePrerelease) {
                 queryBuilder.AdditionalParameters["includePrerelease"] = "true";
                 if (_isJFrogRepo) {
+                    // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsAbsoluteLatestVersion correctly
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");
                 }
                 else {
@@ -1075,6 +1081,7 @@ private string FindNameGlobbing(string packageName, ResourceType type, bool incl
                 }
             } else {
                 if (_isJFrogRepo) {
+                    // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsLatestVersion correctly
                     filterBuilder.AddCriterion("IsLatestVersion eq true");
                 }
                 else {
@@ -1174,6 +1181,7 @@ private string FindNameGlobbingWithTag(string packageName, string[] tags, Resour
             if (includePrerelease) {
                 queryBuilder.AdditionalParameters["includePrerelease"] = "true";
                 if (_isJFrogRepo) {
+                    // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsAbsoluteLatestVersion correctly
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");
                 }
                 else {
@@ -1182,6 +1190,7 @@ private string FindNameGlobbingWithTag(string packageName, string[] tags, Resour
                 }
             } else {
                 if (_isJFrogRepo) {
+                    // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsLatestVersion correctly
                     filterBuilder.AddCriterion("IsLatestVersion eq true");
                 }
                 else {

Original file line number	Diff line number	Diff line change
`@@ -918,8 +918,10 @@ private string FindAllFromTypeEndPoint(bool includePrerelease, bool isSearchingM`
`918`	`918`
`919`	`919`	`if (includePrerelease) {`
`920`	`920`	`queryBuilder.AdditionalParameters["includePrerelease"] = "true";`
	`921`	`+ // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsAbsoluteLatestVersion correctly`
`921`	`922`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");`
`922`	`923`	`} else {`
	`924`	`+ // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsLatestVersion correctly`
`923`	`925`	`filterBuilder.AddCriterion("IsLatestVersion eq true");`
`924`	`926`	`}`
`925`	`927`	`}`
`@@ -965,6 +967,7 @@ private string FindTagFromEndpoint(string[] tags, bool includePrerelease, bool i`
`965`	`967`	`if (includePrerelease) {`
`966`	`968`	`queryBuilder.AdditionalParameters["includePrerelease"] = "true";`
`967`	`969`	`if (_isJFrogRepo) {`
	`970`	`+ // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsAbsoluteLatestVersion correctly`
`968`	`971`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");`
`969`	`972`	`}`
`970`	`973`	`else {`
`@@ -1014,6 +1017,7 @@ private string FindCommandOrDscResource(string[] tags, bool includePrerelease, b`
`1014`	`1017`	`if (includePrerelease) {`
`1015`	`1018`	`queryBuilder.AdditionalParameters["includePrerelease"] = "true";`
`1016`	`1019`	`if (_isJFrogRepo) {`
	`1020`	`+ // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsAbsoluteLatestVersion correctly`
`1017`	`1021`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");`
`1018`	`1022`	`}`
`1019`	`1023`	`else {`
`@@ -1022,6 +1026,7 @@ private string FindCommandOrDscResource(string[] tags, bool includePrerelease, b`
`1022`	`1026`	`}`
`1023`	`1027`	`} else {`
`1024`	`1028`	`if (_isJFrogRepo) {`
	`1029`	`+ // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsLatestVersion correctly`
`1025`	`1030`	`filterBuilder.AddCriterion("IsLatestVersion eq true");`
`1026`	`1031`	`}`
`1027`	`1032`	`else {`
`@@ -1067,6 +1072,7 @@ private string FindNameGlobbing(string packageName, ResourceType type, bool incl`
`1067`	`1072`	`if (includePrerelease) {`
`1068`	`1073`	`queryBuilder.AdditionalParameters["includePrerelease"] = "true";`
`1069`	`1074`	`if (_isJFrogRepo) {`
	`1075`	`+ // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsAbsoluteLatestVersion correctly`
`1070`	`1076`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");`
`1071`	`1077`	`}`
`1072`	`1078`	`else {`
`@@ -1075,6 +1081,7 @@ private string FindNameGlobbing(string packageName, ResourceType type, bool incl`
`1075`	`1081`	`}`
`1076`	`1082`	`} else {`
`1077`	`1083`	`if (_isJFrogRepo) {`
	`1084`	`+ // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsLatestVersion correctly`
`1078`	`1085`	`filterBuilder.AddCriterion("IsLatestVersion eq true");`
`1079`	`1086`	`}`
`1080`	`1087`	`else {`
`@@ -1174,6 +1181,7 @@ private string FindNameGlobbingWithTag(string packageName, string[] tags, Resour`
`1174`	`1181`	`if (includePrerelease) {`
`1175`	`1182`	`queryBuilder.AdditionalParameters["includePrerelease"] = "true";`
`1176`	`1183`	`if (_isJFrogRepo) {`
	`1184`	`+ // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsAbsoluteLatestVersion correctly`
`1177`	`1185`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");`
`1178`	`1186`	`}`
`1179`	`1187`	`else {`
`@@ -1182,6 +1190,7 @@ private string FindNameGlobbingWithTag(string packageName, string[] tags, Resour`
`1182`	`1190`	`}`
`1183`	`1191`	`} else {`
`1184`	`1192`	`if (_isJFrogRepo) {`
	`1193`	`+ // note: we add 'eq true' because some PMPs (currently we know of JFrog, but others may do this too) will proxy the query unedited to the upstream remote and if that's PSGallery, it doesn't handle IsLatestVersion correctly`
`1185`	`1194`	`filterBuilder.AddCriterion("IsLatestVersion eq true");`
`1186`	`1195`	`}`
`1187`	`1196`	`else {`