Add tests

Author: anamnavi

src/code/PublishPSResource.cs

@@ -155,7 +155,7 @@ protected override void BeginProcessing()
                     if (repository is null || repository.ApiVersion != PSRepositoryInfo.APIVersion.ContainerRegistry)
                     {
                         ThrowTerminatingError(new ErrorRecord(
-                            new PSInvalidOperationException("ModulePrefix parameter can only be provided with the Repository parameter for a registered repository of type 'ContainerRegistry'"),
+                            new PSInvalidOperationException("ModulePrefix parameter can only be provided for a registered repository of type 'ContainerRegistry'"),
                             "ModulePrefixParameterIncorrectlyProvided",
                             ErrorCategory.InvalidOperation,
                             this));

test/PublishPSResourceTests/PublishPSResource.Tests.ps1

@@ -99,6 +99,8 @@ Describe "Test Publish-PSResource" -tags 'CI' {
 
         # Create test module with missing required module
         CreateTestModule -Path $TestDrive -ModuleName 'ModuleWithMissingRequiredModule'
+
+        $script:PSGalleryName = 'PSGallery'
     }
     AfterAll {
        Get-RevertPSResourceRepositoryFile
@@ -149,6 +151,44 @@ Describe "Test Publish-PSResource" -tags 'CI' {
         (Get-ChildItem $script:repositoryPath).FullName | Should -Be $expectedPath
     }
 
+    It "Publish should create PSResourceRepository.xml file if its not there" {
+        # Remove the PSResourceRepository.xml file
+        $powerShellGetPath = Join-Path -Path ([Environment]::GetFolderPath([System.Environment+SpecialFolder]::LocalApplicationData)) -ChildPath "PSResourceGet"
+        $originalXmlFilePath = Join-Path -Path $powerShellGetPath -ChildPath "PSResourceRepository.xml" #this is the temporary PSResourceRepository.xml file created in the 'BeforeAll' section of this test file
+
+        $tempXmlFilePath = Join-Path -Path $powerShellGetPath -ChildPath "tempfortest.xml"
+
+        if (Test-Path -Path $originalXmlFilePath) {
+            Copy-Item -Path $originalXmlFilePath -Destination $tempXmlFilePath
+            Remove-Item -Path $originalXmlFilePath -Force -ErrorAction Ignore
+        }
+
+        # Attempt to publish.
+        # Publish-PSResource should create PSResourceRepository.xml file if not present. It will register the 'PSGallery' repository as a default, so this test will still fail
+        # But we can ensure the PSResourceRepository.xml file is created.
+        $version = "1.0.0"
+        New-ModuleManifest -Path (Join-Path -Path $script:PublishModuleBase -ChildPath "$script:PublishModuleName.psd1") -ModuleVersion $version -Description "$script:PublishModuleName module"
+
+        Publish-PSResource -Path $script:PublishModuleBase -Repository $testRepository2 -ErrorVariable err -ErrorAction SilentlyContinue
+        $err[0].FullyQualifiedErrorId | Should -Be "RepositoryNotRegistered,Microsoft.PowerShell.PSResourceGet.Cmdlets.PublishPSResource"
+
+        $registeredRepos = Get-PSResourceRepository
+        $registeredRepos.Count | Should -Be 1
+        $registeredRepos[0].Name | Should -Be $script:PSGalleryName
+
+        # Cleanup
+        # Remove the new PSResourceRepository.xml file created by the Publish-PSResource command and put back the original created in the 'BeforeAll' section of this test file
+        if (Test-Path -Path $tempXmlFilePath) {
+            Copy-Item -Path $tempXmlFilePath -Destination $originalXmlFilePath -Force -Verbose
+            Remove-Item -Path $tempXmlFilePath -Force -ErrorAction Ignore
+        }
+
+        # Verify old repositories are restored
+        $originalRegisteredRepo = Get-PSResourceRepository -Name $testRepository2 -ErrorVariable err2 -ErrorAction SilentlyContinue
+        $err2.Count | Should -Be 0
+        $originalRegisteredRepo.Name | Should -Be $testRepository2
+    }
+
 	#region Local Source Path
     It "Publish a module with -Path and -Repository" {
         $version = "1.0.0"

test/PublishPSResourceTests/PublishPSResourceContainerRegistryServer.Tests.ps1

@@ -100,6 +100,8 @@ Describe "Test Publish-PSResource" -tags 'CI' {
 
         # Path to specifically to that invalid test nupkgs folder
         $script:testNupkgsFolderPath = Join-Path $script:testFilesFolderPath -ChildPath "testNupkgs"
+
+        $script:PSGalleryName = "PSGallery"
     }
     AfterEach {
         if(!(Test-Path $script:PublishModuleBase))
@@ -515,6 +517,27 @@ Describe "Test Publish-PSResource" -tags 'CI' {
         $results[0].Version | Should -Be $version
     }
 
+    It "not Publish a resource when ModulePrefix is given for a Repository that is not of type ContainerRegistry" 
+    {
+        $version = "1.0.0"
+        $modulePrefix = "unlisted"
+        New-ModuleManifest -Path (Join-Path -Path $script:PublishModuleBase -ChildPath "$script:PublishModuleName.psd1") -ModuleVersion $version -Description "$script:PublishModuleName module"
+
+        Publish-PSResource -Path $script:PublishModuleBase -Repository $script:PSGalleryName -ModulePrefix $modulePrefix -ErrorVariable err -ErrorAction SilentlyContinue
+        $err.Count | Should -Not -Be 0
+        $err[0].FullyQualifiedErrorId | Should -BeExactly "ModulePrefixParameterIncorrectlyProvided,Microsoft.PowerShell.PSResourceGet.Cmdlets.PublishPSResource"
+    }
+
+    It "not Publish a resource when ModulePrefix is provided without Repository parameter" {
+        $version = "1.0.0"
+        $modulePrefix = "unlisted"
+        New-ModuleManifest -Path (Join-Path -Path $script:PublishModuleBase -ChildPath "$script:PublishModuleName.psd1") -ModuleVersion $version -Description "$script:PublishModuleName module"
+
+        Publish-PSResource -Path $script:PublishModuleBase -ModulePrefix $modulePrefix -ErrorVariable err -ErrorAction SilentlyContinue
+        $err.Count | Should -Not -Be 0
+        $err[0].FullyQualifiedErrorId | Should -BeExactly "ModulePrefixParameterProvidedWithoutRepositoryParameter,Microsoft.PowerShell.PSResourceGet.Cmdlets.PublishPSResource"
+    }
+
     It "Publish a package given NupkgPath to a package with .psd1" {
         $packageName = "temp-testmodule-nupkgpath"
         $version = "1.0.0.0"