Fix 1659 "Some Nuget packages fail to extract"

[o-l-a-v]

PR Summary

Fixes #1659.

I noticed that the example problematic package Microsoft.Web.WebView2 ( https://www.nuget.org/packages/Microsoft.Web.WebView2 ) mentioned by the creator of the issue, contained directories when doing ZipFile.OpenRead and looking at the entries. Non-problematic packages, like NuGet.Versioning ( https://www.nuget.org/packages/NuGet.Versioning ) did not.

Solution: Filter out entries where length is less than or equal to 0 (because they are not files).

PR Context

See previous chapter.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Documentation needed
    • Issue filed:
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

[o-l-a-v]

We should probably add a test to make sure this does not happen again? But you probably want another "test_modulex" rather testing by fetching Microsoft.Web.WebView2 ( https://www.nuget.org/packages/Microsoft.Web.WebView2 )?

Must be a .nupkg where ZipFile.OpenRead will have entries where CompressedLength is less than 1, a.k.a a directory.

[alerickson]

So funny enough, when I tried to create a similarly structured .nupkg I wasn't able to repro the issue-- the only entries displayed were files and not directories.

I added a version of Microsoft.Web.WebView2 that is definitely reproducing the error and added a test to the local repository test file to validate it can install properly.

Thanks for fixing this bug!