Add -AcceptLicense to Save-PSResource

[o-l-a-v]

PR Summary

Fixes #1450, but:

• Tests likely requires more work as Save-PSResource accepted license by default previously:

  • PSResourceGet/src/code/SavePSResource.cs

    Line 291 in fe9c4d6

    acceptLicense: true,

• Documentation for Save-PSResource must be updated, unless that happens automagically?

PR Context

To fix said issue.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Documentation needed
    • Issue filed:
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed: Add -AcceptLicense to Save-PSResource if PSResourceGet #1718 gets merged MicrosoftDocs/PowerShell-Docs-PSGet#160
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

[alerickson]

Hi @o-l-a-v thanks for the PR, more than happy to update the other tests if you can give me permission to make changes to your branch. Otherwise could you add the -AcceptLicense parameter to the previous Save-PSResource tests and have the new test verify that it does not save if -AcceptLicense is not passed in?

[o-l-a-v]

@alerickson This means you can push to this branch too, right? I ask because I don't know.

If you need written consent: I consent. 🙂

---

Otherwise could you add the -AcceptLicense parameter to the previous Save-PSResource tests and have the new test verify that it does not save if -AcceptLicense is not passed in?

Only test_module_with_license should require -AcceptLicense, right? So adding -AcceptLicense to all other tests should not be neccessary?

[alerickson]

/azp PowerShell.PSResourceGet

[azure-pipelines]

Command 'PowerShell.PSResourceGet' is not supported by Azure Pipelines.

Supported commands

• help:
• Get descriptions, examples and documentation about supported commands
• Example: help "command_name"
• list:
• List all pipelines for this repository using a comment.
• Example: "list"
• run:
• Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
• Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
• where:
• Report back the Azure DevOps orgs that are related to this repository and org
• Example: "where"

See additional documentation.

[alerickson]

/azp run PowerShell.PSResourceGet

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[alerickson]

This PR looks good, just waiting on some CI issues to be resolved and then will merge in!