Skip to content

Add 'ToLower' before name comparison and split #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Oct 29, 2024
Merged

Add 'ToLower' before name comparison and split #1738

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
3403f5e
Add 'ToLower' before name comparison and split
alerickson Oct 25, 2024
a5f92ca
Update PSResourceGet version installed for CI
alerickson Oct 25, 2024
29d90b8
Add logging
alerickson Oct 25, 2024
0ae8672
Add more logging to understand psget version used
alerickson Oct 25, 2024
606e026
Use stable version of psget for CI
alerickson Oct 25, 2024
056ac6c
Lower psget version to 1.0.2
alerickson Oct 25, 2024
c933c7c
Use current build for psget ci
alerickson Oct 25, 2024
2782953
Remove -Confirm param
alerickson Oct 25, 2024
e5a727d
Add debugging
alerickson Oct 26, 2024
fe36692
Add more logging
alerickson Oct 26, 2024
a748b43
Fix test logging
alerickson Oct 28, 2024
56a1a3a
Add missing }
alerickson Oct 28, 2024
66dfa11
GCI on local repo
alerickson Oct 28, 2024
f81cd25
Add logging in installhelper
alerickson Oct 28, 2024
51d46f5
Add more logging for unpacking zip
alerickson Oct 28, 2024
53b9d72
Add bug fix for retrieving pkg name from local repos
alerickson Oct 28, 2024
5047249
Remove logging
alerickson Oct 28, 2024
46bbabe
Clean up tests and extra logging
alerickson Oct 28, 2024
6f54173
More clean up
alerickson Oct 28, 2024
f459db1
Add tests
alerickson Oct 28, 2024
3bdeaad
Clean up whitespace
alerickson Oct 28, 2024
b087965
Create new pkg for test on finding pkg name with correct casing
alerickson Oct 28, 2024
9e5e287
Change version in test
alerickson Oct 29, 2024
bb87962
Update publish local tests
alerickson Oct 29, 2024
9dca504
Fix spelling error
alerickson Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/code/LocalServerApiCalls.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@ private NuGetVersion GetInfoFromFileName(string packageFullName, string packageN

string[] packageWithoutName = packageFullName.ToLower().Split(new string[]{ $"{packageName.ToLower()}." }, StringSplitOptions.RemoveEmptyEntries);
string packageVersionAndExtension = packageWithoutName[0];
string[] originalFileNameParts = packageFullName.Split(new string[]{ $".{packageVersionAndExtension}" }, StringSplitOptions.RemoveEmptyEntries);
string[] originalFileNameParts = packageFullName.ToLower().Split(new string[]{ $".{packageVersionAndExtension.ToLower()}" }, StringSplitOptions.RemoveEmptyEntries);
actualName = String.IsNullOrEmpty(originalFileNameParts[0]) ? packageName : originalFileNameParts[0];
int extensionDot = packageVersionAndExtension.LastIndexOf('.');
string version = packageVersionAndExtension.Substring(0, extensionDot);
Expand Down
Loading