Skip to content

Fix package name regex to account for 4 digit versions #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Fix package name regex to account for 4 digit versions #1739

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
549f700
Fix package name regex to account for 4 digit versions
anamnavi Oct 25, 2024
6af57fc
account for 4 digit
anamnavi Oct 25, 2024
664c060
account for prerelease label having - wherever and having digits
anamnavi Oct 25, 2024
f9e3d57
Merge branch 'master' of https://github.com/PowerShell/PSResourceGet …
anamnavi Oct 30, 2024
342ccfd
add test for local repo with 4 digit and prerelease version
anamnavi Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/code/LocalServerApiCalls.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ private FindResults FindNameHelper(string packageName, string[] tags, bool inclu
string actualPkgName = packageName;

// this regex pattern matches packageName followed by a version (4 digit or 3 with prerelease word)
string regexPattern = $"{packageName}" + @".\d+\.\d+\.\d+(?:-\w+|.\d)*.nupkg";
string regexPattern = $"{packageName}" + @".\d+\.\d+\.\d+(?:[a-zA-Z0-9-.]+|.\d)?.nupkg";
Regex rx = new Regex(regexPattern, RegexOptions.Compiled | RegexOptions.IgnoreCase);
_cmdletPassedIn.WriteDebug($"package file name pattern to be searched for is: {regexPattern}");

Expand Down
Loading