Skip to content

Conversation

anamnavi
Copy link
Member

When consuming a package from a container registry, we have a certain logic to look for the package's dependencies. For Az* packages the dependencies are in ModuleList and that criteria logic needs to be updated.

PR Summary

PR Context

PR Checklist

}

if (string.Equals(packageName, "Az", StringComparison.OrdinalIgnoreCase) || packageName.StartsWith("Az.", StringComparison.OrdinalIgnoreCase))
if (packageName.StartsWith("Az", StringComparison.OrdinalIgnoreCase))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer explicitly adding AzPreview. Otherwise it might match other modules like azereo, AzDOCmd, AzFnUtil etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though these modules are not on MAR, this code is going to be shared with ACR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a test for AzPreview

@anamnavi anamnavi closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants