-
Notifications
You must be signed in to change notification settings - Fork 100
Implement pagination for receiving MCR catalog items #1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+83
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
alerickson
approved these changes
Sep 12, 2025
be7670b
to
b3966a7
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
alerickson
approved these changes
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request enhances the Azure Container Registry repository listing functionality by adding support for paginated API responses. The main improvement ensures that all repositories are retrieved, even when the server returns results across multiple pages. The most important changes are:
Pagination Support for Repository Listing:
FindAllRepositories
to callGetHttpResponseJObjectUsingDefaultHeaders
with a newusePagination
parameter set totrue
, enabling paginated retrieval of repositories.GetHttpResponseJObjectUsingDefaultHeaders
to accept ausePagination
flag and, when enabled, route requests through a new pagination-aware method. [1] [2]SendRequestAsyncWithPagination
, which iteratively follows pagination links in the HTTP response headers (Link: ... rel="next"
) to aggregate all repository results into a singleJObject
.Code Cleanup and Refactoring:
using
directives at the top ofContainerRegistryServerAPICalls.cs
for improved readability and maintainability.PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.