-
Notifications
You must be signed in to change notification settings - Fork 100
Fix 1823 - MAR fails to parse RequiredVersion for dependencies #1876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alerickson
merged 10 commits into
PowerShell:master
from
o-l-a-v:fix-1823-mar-dependencies-version-range
Oct 2, 2025
Merged
Fix 1823 - MAR fails to parse RequiredVersion for dependencies #1876
alerickson
merged 10 commits into
PowerShell:master
from
o-l-a-v:fix-1823-mar-dependencies-version-range
Oct 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a test for this too. It "Should find version range for Az dependencies" {
# Target known version to know the output from the API won't change
$res = Find-PSResource -Repository 'MAR' -Name 'Az' -Version '14.4.0'
# Version defined by "ModuleVersion"
$res.Dependencies.Where{$_.'Name' -eq 'Az.Accounts'}.'VersionRange'.ToString() | Should -Be '[5.3.0, )'
# Version defined by "RequiredVersion"
$res.Dependencies.Where{$_.'Name' -eq 'Az.Resources'}.'VersionRange'.ToString() | Should -Not -Be '[8.1.0, 8.1.0]'
} |
alerickson
requested changes
Sep 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good over all, just a test failure with 'Should find version range for Az dependencies'
Expected '[8.1.0, 8.1.0]' to be different from the actual value, but got the same value. 321: $res.Dependencies.Where{$_.'Name' -eq 'Az.Resources'}.'VersionRange'.ToString() | Should -Not -Be '[8.1.0, 8.1.0]' at <ScriptBlock>, D:\a\1\s\test\FindPSResourceTests\FindPSResourceContainerRegistryServer.Tests.ps1: line 321
Oops, I fixed the test goof now @alerickson. 😊 |
alerickson
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
A little goof in an if statement in
PSResourceInfo.cs
made it so that PSResourceGet failed to get version range for dependencies whereRequiredVersion
was specified.Fixes #1823
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.