Skip to content

Add warning when AuthenticodeCheck is used on non-Windows platforms #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Add warning when AuthenticodeCheck is used on non-Windows platforms #1891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91c5218
Initial plan
Copilot Oct 8, 2025
2d2c478
Add warning for AuthenticodeCheck on non-Windows platforms
Copilot Oct 8, 2025
ed2ce91
Add tests for AuthenticodeCheck warning in Save and Update cmdlets
Copilot Oct 8, 2025
a542b97
Remove redundant tests
alerickson Oct 8, 2025
4a06e52
Update test
alerickson Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/code/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2160,6 +2160,7 @@ internal static bool CheckAuthenticodeSignature(
// Because authenticode and catalog verifications are only applicable on Windows, we allow all packages by default to be installed on unix systems.
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
cmdletPassedIn.WriteWarning("Authenticode check cannot be performed on Linux or MacOS.");
return true;
}

Expand Down
8 changes: 8 additions & 0 deletions test/InstallPSResourceTests/InstallPSResourceV2Server.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,14 @@ Describe 'Test Install-PSResource for V2 Server scenarios' -tags 'CI' {
$err[0].FullyQualifiedErrorId | Should -BeExactly "GetAuthenticodeSignatureError,Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallPSResource"
}

# Test that AuthenticodeCheck parameter displays warning on non-Windows
It "Install with AuthenticodeCheck on non-Windows should display warning" -Skip:(Get-IsWindows) {
Install-PSResource -Name $testModuleName -Repository $PSGalleryName -TrustRepository -AuthenticodeCheck -WarningVariable warn -WarningAction SilentlyContinue
$warn[0] | Should -Contain "Authenticode check cannot be performed on Linux or MacOS"
$res = Get-InstalledPSResource $testModuleName
$res.Name | Should -Be $testModuleName
}

# Unix test for installing scripts
It "Install script resource - Unix only" -Skip:(Get-IsWindows) {
# previously installing pester on Unix was throwing an error due to how the environment PATH variable was being gotten.
Expand Down
Loading