Skip to content

Conversation

@tgauth
Copy link
Collaborator

@tgauth tgauth commented Jan 7, 2026

Copilot AI review requested due to automatic review settings January 7, 2026 20:28
@tgauth tgauth changed the title replace colon in filename with underscore [ssh-keygen] fix fido2 key filename translation on Windows Jan 7, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #2418 by replacing colons with underscores in filenames on Windows, where colons are not valid filename characters outside of drive letters.

Key changes:

  • Adds Windows-specific code to sanitize filenames by replacing colons with underscores in the sk_suffix function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <[email protected]>
@tgauth
Copy link
Collaborator Author

tgauth commented Jan 7, 2026

/azp run

@tgauth tgauth requested a review from vthiebaut10 January 7, 2026 20:31
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fido2 key filename should remove colon in filename

1 participant