Skip to content

Conversation

o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Nov 8, 2024

PR Summary

Closes #5086

  • Fix invalid JSON file for snippets.
  • Added test suggestion for testing that the project only contains valid JSON files.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@o-l-a-v o-l-a-v requested a review from a team as a code owner November 8, 2024 13:57
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks!

o-l-a-v and others added 3 commits November 13, 2024 19:16
Co-authored-by: Andy Jordan <[email protected]>
Co-authored-by: Andy Jordan <[email protected]>
@andyleejordan andyleejordan added this pull request to the merge queue Nov 13, 2024
@andyleejordan
Copy link
Member

Well that was annoying. A transitive dependency updated (I think the SDK does this when it runs in CI?) and I had to add three different iterations of essentially the same package to the Azure Artifacts feed. It's running again now.

Merged via the queue into PowerShell:main with commit a8b28e0 Nov 13, 2024
4 checks passed
@o-l-a-v o-l-a-v deleted the fix-snippet-json-file branch November 13, 2024 23:07
@andyleejordan andyleejordan added the Issue-Bug A bug to squash. label Nov 15, 2024
@Cydroz Cydroz mentioned this pull request Jan 6, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in foreach-progress snippet
2 participants