This repository was archived by the owner on Apr 24, 2020. It is now read-only.
[Enhancement] allow go_version prompt to work with go modules#1287
Open
reynn wants to merge 1 commit intoPowerlevel9k:nextfrom
reynn:next
Open
[Enhancement] allow go_version prompt to work with go modules#1287reynn wants to merge 1 commit intoPowerlevel9k:nextfrom reynn:next
reynn wants to merge 1 commit intoPowerlevel9k:nextfrom
reynn:next
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Go 1.11 introduced modules which allow go projects to no longer need to be in a static GOPATH. This PR will let Go devs see the Go version even if they are using modules.
Questions
I couldn't find any testing around these prompts, if there is somewhere I missed please let me know and I'll update.