Skip to content

fix(array): add missing header to make MSVC happy#50

Merged
PragmaTwice merged 1 commit intoPragmaTwice:masterfrom
alk3p:master
May 7, 2025
Merged

fix(array): add missing header to make MSVC happy#50
PragmaTwice merged 1 commit intoPragmaTwice:masterfrom
alk3p:master

Conversation

@alk3pInjection
Copy link
Contributor

include\protopuf\array.h(134): error C2039: 'basic_string': is not a member of 'std'

@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (4a42c9a) to head (8e6cc43).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files          29       29           
  Lines         892      892           
  Branches       22       22           
=======================================
  Hits          881      881           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PragmaTwice PragmaTwice changed the title fix(array): Add missing header to make MSVC happy fix(array): add missing header to make MSVC happy May 7, 2025
Copy link
Owner

@PragmaTwice PragmaTwice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you also provide the version of MSVC you are using?

@alk3pInjection
Copy link
Contributor Author

alk3pInjection commented May 7, 2025

Thank you! Could you also provide the version of MSVC you are using?

19.42.34441 from Visual Studio 2022 v17.12.7

@PragmaTwice PragmaTwice merged commit d6a65ba into PragmaTwice:master May 7, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants