fix(array): add missing header to make MSVC happy#50
Merged
PragmaTwice merged 1 commit intoPragmaTwice:masterfrom May 7, 2025
alk3p:master
Merged
fix(array): add missing header to make MSVC happy#50PragmaTwice merged 1 commit intoPragmaTwice:masterfrom alk3p:master
PragmaTwice merged 1 commit intoPragmaTwice:masterfrom
alk3p:master
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
=======================================
Coverage 98.76% 98.76%
=======================================
Files 29 29
Lines 892 892
Branches 22 22
=======================================
Hits 881 881
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PragmaTwice
approved these changes
May 7, 2025
Owner
PragmaTwice
left a comment
There was a problem hiding this comment.
Thank you! Could you also provide the version of MSVC you are using?
Contributor
Author
19.42.34441 from Visual Studio 2022 v17.12.7 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include\protopuf\array.h(134): error C2039: 'basic_string': is not a member of 'std'