Feature/dataset creation navigation options#29
Open
Praise-creator wants to merge 4 commits intomasterfrom
Open
Feature/dataset creation navigation options#29Praise-creator wants to merge 4 commits intomasterfrom
Praise-creator wants to merge 4 commits intomasterfrom
Conversation
… place below "Sort Query By" in aggregation mode
- Add 'Enable Zoom' checkbox control in Chart Options - Implement ECharts dataZoom with slider and inside types - Support mouse wheel zoom and click-drag pan interactions - Adjust grid bottom padding when zoom is enabled - Default zoom to disabled for backward compatibility
…avigation - Convert create button to ButtonGroup with dropdown menu - Add 'Create dataset' option that navigates to dataset list - Maintain 'Create dataset and create chart' as default behavior - Update tests to reflect new button text and structure - Follows existing Superset patterns using ButtonGroup and Dropdown components"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Motivation
Users are forced to navigate to chart creation after creating a dataset, even when they just want to organize datasets or create them for later use. This adds unnecessary friction.
Changes
Converted single "Create" button to a split button with dropdown menu
Primary button: "Create dataset and create chart" → navigates to chart creation (preserves existing behavior)
Dropdown option: "Create dataset" → navigates back to dataset list
Updated onsave function to accept navigatetochart parameter for routing logic
Updated test selectors to match new button labels
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
TESTING INSTRUCTIONS
Manual Testing:
/tablemodelview/list/(the dataset list page)ADDITIONAL INFORMATION
Fixes Issue #20 - [FEATURE] Add option to create dataset without automatically creating a chart #27