Open
Conversation
… place below "Sort Query By" in aggregation mode
- Add 'Enable Zoom' checkbox control in Chart Options - Implement ECharts dataZoom with slider and inside types - Support mouse wheel zoom and click-drag pan interactions - Adjust grid bottom padding when zoom is enabled - Default zoom to disabled for backward compatibility
…avigation - Convert create button to ButtonGroup with dropdown menu - Add 'Create dataset' option that navigates to dataset list - Maintain 'Create dataset and create chart' as default behavior - Update tests to reflect new button text and structure - Follows existing Superset patterns using ButtonGroup and Dropdown components"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removed deprecated database support references from workspace.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
Manual Verification:
Search the entire codebase for "rockset" (case-insensitive) - should find no meaningful references
Review the README.md - confirm Rockset logo is not displayed among supported databases
Check the database configuration documentation - confirm no Rockset connection instructions exist
Review pyproject.toml - confirm no rockset-sqlalchemy dependency is listed
Automated Verification:
Run the test suite to ensure no tests are broken by the removal: pytest tests/
Verify the project builds successfully without the Rockset dependency
Check that documentation builds without errors: cd docs && npm run build (if applicable)
Run linting to ensure code quality is maintained: pre-commit run --all-files
ADDITIONAL INFORMATION
Fixes #28