feat(Kleinanzeigen): add activity #10304
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
theusaf
requested changes
Jan 3, 2026
websites/K/Kleinanzeigen/presence.ts
Outdated
Comment on lines
51
to
58
| const strings = { | ||
| de: { viewingAd: 'Anzeige ansehen', seller: 'Verkäufer', unknown: 'Unbekannt', topSatisfaction: 'TOP Zufriedenheit', veryFriendly: 'Sehr freundlich', reliable: 'Zuverlässig', viewAd: 'Anzeige ansehen', viewSeller: 'Verkäufer ansehen', searchingFor: 'Sucht nach', page: 'Seite', of: 'von', more: 'weitere', noFilters: 'Keine Filter', viewSearch: 'Suche ansehen', managingAds: 'Anzeigen verwalten', myAds: 'Meine Anzeigen', readingMessages: 'Nachrichten lesen', inbox: 'Posteingang', inSettings: 'In den Einstellungen', managingProfileInfo: 'Profilinformationen verwalten', managingAccountSettings: 'Kontoeinstellungen verwalten', managingPaymentMethods: 'Zahlungsmethoden verwalten', managingPur: 'Kleinanzeigen Pur verwalten', activePur: 'Aktives Kleinanzeigen Pur Abo', inactivePur: 'Inaktives Kleinanzeigen Pur Abo', managingDataProtection: 'Datenschutzeinstellungen verwalten', managingEmailSettings: 'E-Mail-Einstellungen verwalten', viewingAbout: 'Informationen über Kleinanzeigen ansehen', viewingHelp: 'Hilfe- und Feedbackseite ansehen', managingAccount: 'Konto verwalten', browsingWatchlist: 'Merkliste durchsuchen', savedAds: 'Gespeicherte Anzeigen', managingUsers: 'Nutzer verwalten', followedSellers: 'Gefolgte Verkäufer', managingSearches: 'Verwaltet Suchaufträge', savedSearches: 'Gespeicherte Suchen', posting: 'Erstellt Anzeige', in: 'in', creatingAd: 'Anzeige erstellen', chooseCategory: 'Kategorie wählen', viewingSellerProfile: 'Verkäuferprofil ansehen:', sellerProfile: 'Verkäuferprofil', viewProfile: 'Profil ansehen', managingNotifications: 'Benachrichtigungen verwalten', onHomepage: 'Auf der Startseite', browsingOffers: 'Angebote durchsuchen', browsingCategory: 'Kategorie durchsuchen', browsingAds: 'Anzeigen durchsuchen', unknownSearch: 'Unbekannte Suche' }, | ||
| en: { viewingAd: 'Viewing an ad', seller: 'Seller', unknown: 'Unknown', topSatisfaction: 'TOP Satisfaction', veryFriendly: 'Very Friendly', reliable: 'Reliable', viewAd: 'View Ad', viewSeller: 'View Seller', searchingFor: 'Searching for', page: 'Page', of: 'of', more: 'more', noFilters: 'No Filters', viewSearch: 'View Search', managingAds: 'Managing ads', myAds: 'My Ads', readingMessages: 'Reading messages', inbox: 'Inbox', inSettings: 'In settings', managingProfileInfo: 'Managing profile information', managingAccountSettings: 'Managing account settings', managingPaymentMethods: 'Managing payment methods', managingPur: 'Managing Kleinanzeigen Pur', activePur: 'Active Kleinanzeigen Pur membership', inactivePur: 'Inactive Kleinanzeigen Pur membership', managingDataProtection: 'Managing data protection settings', managingEmailSettings: 'Managing email settings', viewingAbout: 'Viewing information about Kleinanzeigen', viewingHelp: 'Viewing the help and feedback page', managingAccount: 'Managing account', browsingWatchlist: 'Browsing watchlist', savedAds: 'Saved Ads', managingUsers: 'Managing users', followedSellers: 'Followed Sellers', managingSearches: 'Managing searches', savedSearches: 'Saved Searches', posting: 'Posting', in: 'in', creatingAd: 'Creating ad', chooseCategory: 'Choose your category', viewingSellerProfile: 'Viewing a seller:', sellerProfile: 'Seller Profile', viewProfile: 'View Profile', managingNotifications: 'Managing notifications', onHomepage: 'On the homepage', browsingOffers: 'Browsing offers', browsingCategory: 'Browsing category', browsingAds: 'Browsing ads', unknownSearch: 'Unknown search' }, | ||
| } | ||
|
|
||
| presence.on('UpdateData', async () => { | ||
| const lang = (await presence.getSetting<string>('lang')) || 'en' | ||
| const t = strings[lang as keyof typeof strings] || strings.de |
Contributor
There was a problem hiding this comment.
Use the provided localization system instead
https://docs.premid.app/v1/guide/localization.html#using-custom-translations
Contributor
Author
There was a problem hiding this comment.
It doesn't work when I added it. It just showed the strings.
Contributor
There was a problem hiding this comment.
Strings verified using an older alpha build
Contributor
Author
There was a problem hiding this comment.
Ah okay thanks, I also fixed the unknown seller issue with the presence in your screenshot, seems like there is a different type of offer which I didn't include 👍
Co-authored-by: Daniel Lau <32113157+theusaf@users.noreply.github.com> Signed-off-by: itsmarian <100617987+itsmarianmc@users.noreply.github.com>
Co-authored-by: Daniel Lau <32113157+theusaf@users.noreply.github.com> Signed-off-by: itsmarian <100617987+itsmarianmc@users.noreply.github.com>
Co-authored-by: Daniel Lau <32113157+theusaf@users.noreply.github.com> Signed-off-by: itsmarian <100617987+itsmarianmc@users.noreply.github.com>
Updated image urls in presence for Kleinanzeigen Updated thumbnail image for Kleinanzeigen Affected files: - websites/K/Kleinanzeigen/Kleinanzeigen.json - websites/K/Kleinanzeigen/metadata.json - websites/K/Kleinanzeigen/presence.ts
Affected files: - websites/K/Kleinanzeigen/Kleinanzeigen.json - websites/K/Kleinanzeigen/presence.ts
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
theusaf
approved these changes
Jan 10, 2026
Bas950
requested changes
Jan 12, 2026
Bas950
requested changes
Jan 24, 2026
Member
Bas950
left a comment
Bas950
left a comment
There was a problem hiding this comment.
Some i18n keys are still in german, kleinanzeigen.globalFarbe for example. Farbe should just be color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected