feat(Dealabs): add activity #10324
Open
feat(Dealabs): add activity #10324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new presence for Dealabs, the largest French community for sharing deals and coupons. **Features:** - 🛍️ **Browsing Deals:** Displays the deal title, price, and "temperature" (votes). - 💬 **Forum:** Shows current discussion topic or forum category. - 🏷️ **Merchants & Groups:** Updates when browsing specific merchants or categories. - 🌍 **Localization:** Fully translated in English and French. - ⚙️ **Settings:** - Privacy Mode (hides specific details globally). - Options to hide prices, images, or titles individually. **Technical details:** - Uses the new `getStrings` object mapping structure. - Validated with both privacy settings and various page types.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Updates the logo to meet the 512x512px requirement and applies ESLint fixes (quotes, semicolons) to match project style.
theusaf
requested changes
Jan 3, 2026
- Revert accidental changes to `cli/src/commands/checkDns.ts` - Implement native localization system using `Dealabs.json` - Update thumbnail to a landscape promotional image in `metadata.json` - Use `ActivityType` enum in `presence.ts` instead of hardcoded value
maximedeprince
force-pushed
the
feat/Dealabs
branch
from
b38666b to
9f60b1f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new presence for Dealabs, a French community platform for sharing deals and coupons. The implementation provides rich activity tracking across different sections of the website including deals, forums, merchants, and categories, with comprehensive privacy settings.
Key Changes:
- Implements a modular resolver pattern for different page types (deals, discussions, merchants, groups, listings)
- Adds granular privacy controls allowing users to hide specific elements
- Provides English translations for user-facing strings
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
| websites/D/Dealabs/presence.ts | Main presence logic orchestrating resolvers and handling activity updates |
| websites/D/Dealabs/util/interfaces.ts | TypeScript interfaces for settings, translations, and resolver pattern |
| websites/D/Dealabs/util/index.ts | Utility functions for slug formatting and content selection |
| websites/D/Dealabs/sources/deal.ts | Resolver for individual deal pages with price and temperature display |
| websites/D/Dealabs/sources/discussion.ts | Resolver for forum discussions |
| websites/D/Dealabs/sources/group.ts | Resolver for category/group pages |
| websites/D/Dealabs/sources/listing.ts | Resolver for feed pages (new, hot, top deals) |
| websites/D/Dealabs/sources/merchant.ts | Resolver for merchant promo code pages |
| websites/D/Dealabs/metadata.json | Service configuration with French-language settings |
| websites/D/Dealabs/Dealabs.json | English translation strings for presence messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new presence for Dealabs, the largest French community for sharing deals and coupons.
✨ Features:
⚙️ Settings:
Technical details:
getStringsmapping for cleaner translation handling.Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected