feat(Hackviser): add activity by efekrbas · Pull Request #10579 · PreMiD/Activities

efekrbas · 2026-03-21T01:41:01Z

Description

Added a new presence for the Hackviser cybersecurity training platform.

Acknowledgements

I read the Activity Guidelines
I linted the code by running npm run lint
The PR title follows the repo's commit conventions

Screenshots

Proof showing the creation/modification is working as expected

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

websites/H/Hackviser/metadata.json

websites/H/Hackviser/presence.ts

github-advanced-security

ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Ensure slug is defined even if parts array is empty. Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

websites/H/Hackviser/presence.ts

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

websites/H/Hackviser/presence.ts

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

websites/H/Hackviser/metadata.json

websites/H/Hackviser/presence.ts

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

websites/H/Hackviser/metadata.json

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

theusaf · 2026-03-23T17:59:59Z

websites/H/Hackviser/bg.jpg

Remove image assets from PR

Remove image assets from PR

I removed

theusaf · 2026-03-23T18:02:11Z

websites/H/Hackviser/metadata.json

+  "regExp": "([a-zA-Z0-9-]+\\.)*hackviser\\.com",
+  "version": "1.0.0",
+  "logo": "https://github.com/user-attachments/assets/609306cf-204f-4916-8940-28e9f789b7ac?.png",
+  "thumbnail": "https://github.com/user-attachments/assets/cf58a97e-0865-4b5e-a363-c709a019150f?.png",


The thumbnail should be a landscape promotional image or screenshot, not the same as the logo

The thumbnail should be a landscape promotional image or screenshot, not the same as the logo

Fixed.

theusaf · 2026-03-23T18:04:11Z

websites/H/Hackviser/presence.ts

+    {
+      label: 'Learn Cybersecurity',
+      url: 'https://hackviser.com/',
+    },


This button is not allowed

This button is not allowed

Removed

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

websites/H/Hackviser/presence.ts

Bas950

did you lint?

websites/H/Hackviser/metadata.json

Bas950 · 2026-03-27T13:51:13Z

websites/H/Hackviser/metadata.json

+    "tr": "Hackviser, laboratuvarlar, CTF yarışmaları, öğrenme yolları ve gerçek dünya senaryoları aracılığıyla siber güvenlik becerilerinizi geliştirebileceğiniz çevrimiçi bir eğitim platformudur."
+  },
+  "url": "hackviser.com",
+  "regExp": "([a-zA-Z0-9-]+\\.)*hackviser\\.com",


Suggested change

"regExp": "([a-zA-Z0-9-]+\\.)*hackviser\\.com",

"regExp": "^https?[:][/][/]([a-zA-Z0-9-]+[.])*hackviser[.]com[/]",

Is there anything else I need to correct? @Bas950

Co-authored-by: Bas van Zanten <bas.van.zanten007@gmail.com> Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

websites/H/Hackviser/metadata.json

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

websites/H/Hackviser/presence.ts

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

websites/H/Hackviser/presence.ts

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

efekrbas · 2026-03-28T22:54:20Z

Could you take a look at it? @Bas950

websites/H/Hackviser/presence.ts

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Add files via upload

7f08e4c

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

github-advanced-security bot found potential problems Mar 21, 2026

View reviewed changes

websites/H/Hackviser/metadata.json Fixed Show fixed Hide fixed

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Mar 21, 2026

View reviewed changes

efekrbas added 5 commits March 21, 2026 04:44

Update metadata.json

7b498a9

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Handle empty slug case in extractPageTitle function

9916b1d

Ensure slug is defined even if parts array is empty. Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Update presence.ts

10ea68e

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Update presence.ts

2b5ee86

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Fix formatting issue in metadata.json

9bf1fa8

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

github-advanced-security bot found potential problems Mar 21, 2026

View reviewed changes

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

Update presence.ts

43daea3

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

github-advanced-security bot found potential problems Mar 21, 2026

View reviewed changes

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

efekrbas added 3 commits March 21, 2026 04:59

Update presence.ts

f6c4919

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Update metadata.json

c4e8c9d

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Update presence.ts

e057b05

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

github-advanced-security bot found potential problems Mar 21, 2026

View reviewed changes

websites/H/Hackviser/metadata.json Fixed Show fixed Hide fixed

websites/H/Hackviser/metadata.json Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Mar 21, 2026

View reviewed changes

Update metadata.json

e286237

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

github-advanced-security bot found potential problems Mar 21, 2026

View reviewed changes

websites/H/Hackviser/metadata.json Fixed Show fixed Hide fixed

websites/H/Hackviser/metadata.json Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Mar 21, 2026

View reviewed changes

websites/H/Hackviser/metadata.json Fixed Show fixed Hide fixed

websites/H/Hackviser/metadata.json Fixed Show fixed Hide fixed

websites/H/Hackviser/metadata.json Fixed Show fixed Hide fixed

websites/H/Hackviser/metadata.json Fixed Show fixed Hide fixed

efekrbas added 6 commits March 21, 2026 05:17

Update metadata.json

09589b0

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Update metadata.json

66c2f03

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Refactor extractPageTitle and getPageData functions

e3022a1

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Delete websites/H/Hackviser/bg.jpg

ec41f2c

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Add files via upload

4c096f8

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Merge branch 'main' into main

a74f427

theusaf added the activity creation label Mar 23, 2026

theusaf changed the title ~~feat(Hackviser): add presence~~ feat(Hackviser): add activity Mar 23, 2026

theusaf requested changes Mar 23, 2026

View reviewed changes

Update presence.ts

5bf3e14

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

github-advanced-security bot found potential problems Mar 23, 2026

View reviewed changes

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

theusaf approved these changes Mar 25, 2026

View reviewed changes

theusaf enabled auto-merge (squash) March 25, 2026 17:51

theusaf requested a review from Bas950 March 25, 2026 17:51

efekrbas added 3 commits March 26, 2026 02:00

Merge branch 'main' into main

1648036

Merge branch 'main' into main

ddd6d1b

Merge branch 'main' into main

a252a37

Bas950 requested changes Mar 27, 2026

View reviewed changes

Update websites/H/Hackviser/metadata.json

355a0e1

Co-authored-by: Bas van Zanten <bas.van.zanten007@gmail.com> Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

auto-merge was automatically disabled March 27, 2026 13:56
Head branch was pushed to by a user without write access

efekrbas requested a review from Bas950 March 27, 2026 13:58

Update metadata.json

364a809

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

github-advanced-security bot found potential problems Mar 27, 2026

View reviewed changes

websites/H/Hackviser/metadata.json Fixed Show fixed Hide fixed

Update presence.ts

5f3011f

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

github-advanced-security bot found potential problems Mar 27, 2026

View reviewed changes

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Mar 27, 2026

View reviewed changes

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

efekrbas added 3 commits March 27, 2026 18:01

Update presence.ts

cf82ac3

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Update metadata.json

3dd8b59

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Update presence.ts

035aa54

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

github-advanced-security bot found potential problems Mar 27, 2026

View reviewed changes

websites/H/Hackviser/presence.ts Fixed Show fixed Hide fixed

Update presence.ts

eb7ee2e

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

Bas950 requested a review from theusaf April 1, 2026 03:38

Bas950 requested changes Apr 1, 2026

View reviewed changes

websites/H/Hackviser/presence.ts Outdated Show resolved Hide resolved

Change presenceData type to PresenceData

307959c

Signed-off-by: Efe Kırbaş <161657597+efekrbas@users.noreply.github.com>

theusaf approved these changes Apr 1, 2026

View reviewed changes

theusaf requested a review from Bas950 April 1, 2026 17:00

theusaf enabled auto-merge (squash) April 1, 2026 17:00

Merge branch 'main' into main

23c56e4

Bas950 approved these changes Apr 2, 2026

View reviewed changes

theusaf merged commit 0d3046d into PreMiD:main Apr 2, 2026
5 checks passed

	"regExp": "([a-zA-Z0-9-]+\\.)*hackviser\\.com",
	"regExp": "^https?[:][/][/]([a-zA-Z0-9-]+[.])*hackviser[.]com[/]",

Uh oh!

Conversation

efekrbas commented Mar 21, 2026

Description

Acknowledgements

Screenshots

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-advanced-security bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Bas950 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

efekrbas commented Mar 28, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants