Draft
Conversation
Add the sync script infrastructure for Watch Party video synchronization: - Sync script compiler and CLI commands (sync-new, sync-dev, sync-build) - YouTube and Disney+ sync script implementations - Global type definitions for SyncScriptV1, SyncIframeScriptV1, SyncMainworldScriptV1 - Comprehensive developer documentation (guide, API reference, examples) - .gitignore rules for syncScripts build artifacts
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
- Fix markdown table alignment in documentation - Add explicit `import process from 'node:process'` in SyncScriptCompiler
The getChangedActivities walker was treating sync script directories as activities because they contain metadata.json. Add syncScripts/ to the endAt list so the walker stops before matching them.
The previous fix added syncScripts to endAt, but that only applies when metadata.json is NOT found. Since sync scripts have their own metadata.json, the walker finds it immediately. Skip files under syncScripts/ entirely before the walk loop.
Convert method signatures to function property syntax to satisfy ts/method-signature-style ESLint rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the complete sync script infrastructure for Watch Party video synchronization across party members.
sync-new,sync-dev,sync-buildcommands with hot-reload dev server and compilerSyncScriptV1,SyncIframeScriptV1,SyncMainworldScriptV1and all related interfaces.gitignorerules for syncScripts build artifactsTest plan
pnpm sync-dev YouTubestarts dev server with hot reloadpnpm sync-build --allcompiles all sync scripts to dist/pnpm sync-new "ExampleService"scaffolds a new sync scriptcd docs && pnpm dev