Conversation
StefanWallin
reviewed
Nov 9, 2022
| }) | ||
| // sen har vi flera paket som ska till till Arjeplog | ||
| range(10).map((id) => | ||
| car.handleBooking(new Booking({ id: `b-${id+2}`, ...ljusdalToArjeplog })) |
Collaborator
There was a problem hiding this comment.
Booking Id's should be unique
| car.handleBooking( | ||
| new Booking({ | ||
| id: 1, | ||
| id: 'b-1', |
Collaborator
There was a problem hiding this comment.
Also changed naming style of booking id's
| toArray() | ||
| ).toPromise() | ||
|
|
||
| expect(log).toEqual([ // TODO: vilken ordning är mest logisk? |
Collaborator
There was a problem hiding this comment.
Några premisser från verkligheten tänker jag:
- När platsen är exakt samma så borde avstigning och urlastning ske före påstigning och lastning. Ändå får vi "AtPickup" före "Delivery" i Ljusdal, förmodligen på grund av ordningen på bokningarna.
Med det sagt är väl inte denna ordning så värst ologisk?
Jag reagerar dock på skillnaden 'Pickup' !== 'AtPickup'
StefanWallin
force-pushed
the
fix/tests
branch
from
ecbdf9d to
99debd9
Compare
Collaborator
|
Rebase:at på ny main, och tacklat ändringar. Lite nya klurigheter har blivit introducerade som kraschar testsviten under körning. Får titta vidare på detta nästa vecka. |
StefanWallin
force-pushed
the
fix/tests
branch
from
92bec3a to
a4be19d
Compare
StefanWallin
force-pushed
the
fix/tests
branch
from
a4be19d to
4e10bc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal: fix all existing tests. 50% done.