-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Support redis serverless (Cluster Mode) #19995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @lordsoffallen - can you update the PR title and body to explain what this PR intends to add and what the motivation is?
for example, in your comments you mention cluster mode but it seems that several other things would need to be updated for cluster mode in general
Hi there, updated. Yes i add redis cluster support so aws redis serverless would work. That's what i have in my setup in the moment and it works afaik. Reference origin: #16299 (comment) |
sorry, @lordsoffallen I'm asking if you can please update the PR body with an explanation for why the specific changes you made are necessary. ie "im adding hash tags for pipeline operations" etc i gather that you're trying to trying to support redis serverless in general, but this PR does not appear to address all that would be needed for full cluster mode support i may not be thinking of everything here, but at least it seems we'd need:
|
|
Hi @zzstoatzz, thanks, regarding the changes: Prior to this, i get redis cluster errors and for messaging these were the needed changes (with claude's help). Right now it works for me, i didn't need further changes but before this i couldn't get prefect background workers running. So I thought i can push them upstream. I am not too familiar with docket so i can't say what's needed so feel free to push changes or close this PR if there are a lot more other changes needed. |
|
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
|
Hi @zzstoatzz I see you guys made updates to docket and so, I am guessing support for serverless coming soon? Any updates on this? 😄 |
Currently it's not possible to use redis serverless with prefect following this setup here: https://docs.prefect.io/v3/advanced/self-hosted
This PR adds support for redis cluster mode so it can work on aws serverless mode. These changes were needed to make sure background services can communicate to prefect api server via redis message broker. (hence the changes in messaging and ordering files)
Checklist
<link to issue>"mint.json.