Handle classic image generation and generate for beta 1#413
Merged
Conversation
Contributor
tleon
commented
Feb 10, 2025
tleon
commented
| Questions | Answers |
|---|---|
| Description? | Changed the generate script to handle classic suffixes in version. Generated the classic version for the 9.0.0-beta-1-classic |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Sponsor company | PrestaShop SA |
| How to test? | CI green |
tleon
force-pushed
the
Handle-clasic-version-generation
branch
6 times, most recently
from
8cb89f0 to
b88a6ac
Compare
9 tasks
nicosomb
approved these changes
Feb 10, 2025
boherm
approved these changes
Feb 10, 2025
Progi1984
reviewed
Feb 11, 2025
Member
Progi1984
left a comment
Progi1984
left a comment
There was a problem hiding this comment.
A simple suggestion : add an unit test via a flavor as classic
And it will be ✔️ for me.
tleon
force-pushed
the
Handle-clasic-version-generation
branch
2 times, most recently
from
3f8b05c to
6f96d93
Compare
Progi1984
approved these changes
Feb 12, 2025
tleon
force-pushed
the
Handle-clasic-version-generation
branch
from
6f96d93 to
9911f83
Compare
Progi1984
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.