Skip to content

Conversation

@Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Jul 23, 2025

Questions Answers
Description? This PR allows the docker images (prestashop/base and prestashop/prestashop) to be built for amd64, arm32 and arm64
Type? new feature
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #315
Sponsor company @PrestaShopCorp
How to test? The existing commands generate the images for different kind of CPUs
  • Given the time needed to build each image (given the emulation of other processors), the GitHub action workflow has been split for each image to generate
image

@Quetzacoalt91 Quetzacoalt91 self-assigned this Jul 23, 2025
@Quetzacoalt91 Quetzacoalt91 changed the title Multi platform Enable build of multi-platform images (amd64, arm32 & arm64) Jul 23, 2025
@Quetzacoalt91 Quetzacoalt91 force-pushed the multi-platform branch 13 times, most recently from 3409749 to 743fafc Compare July 25, 2025 16:39
@Quetzacoalt91
Copy link
Member Author

Quetzacoalt91 commented Jul 28, 2025

Oh no, the workflow is being cancelled after 6 hours because it reached the timeout.

Capture d’écran du 2025-07-25 23-58-57

We can't use a single runner to build all the platforms at once. We'll have to split each job in two (amd64 an arm64) then merge their manifests.
--> https://docs.docker.com/build/ci/github-actions/multi-platform/#build-and-load-multi-platform-images

I actually had an infinite loop in the script... Let's try again before having to split the run

@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Aug 6, 2025
@tyloo
Copy link

tyloo commented Aug 6, 2025

Hey @Quetzacoalt91 ! Thanks for this PR! We, Mac arm users would really need this one. Any ETA on this? Thanks

@Quetzacoalt91
Copy link
Member Author

The PR is ready for review , so it can be very soon. However note we should merge it outside the peak hours, because some of the jobs that will be triggered to build the images will need 50min to complete and we're limited to 10 runners on this GitHub organization.

@Quetzacoalt91 Quetzacoalt91 merged commit 515faa6 into PrestaShop:master Aug 7, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from To be tested to Merged in PR Dashboard Aug 7, 2025
@Quetzacoalt91 Quetzacoalt91 deleted the multi-platform branch August 7, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

docker: no matching manifest for linux/arm64/v8 in the manifest list entries.

4 participants