Skip to content

Add missing extraction logic in nightly script #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Quetzacoalt91 merged 1 commit into from
Sep 3, 2025
Merged

Add missing extraction logic in nightly script #447

Quetzacoalt91 merged 1 commit into from
Sep 3, 2025

Conversation

@tleon
Copy link
Contributor

@tleon tleon commented Sep 2, 2025 •
edited
Loading

…hing

Questions Answers
Description? The nightly script was deleted in this PR following an update. It seems some of the logic of this script was not ported to the new version
Type? bug fix
BC breaks? yes
Deprecations? yes
Fixed ticket? Fixes #39497
Sponsor company PrestaShop SA
How to test? CI green

@tleon tleon self-assigned this Sep 2, 2025
@tleon tleon force-pushed the fix-nightly-image-9.0.x_8.2 branch 2 times, most recently from c75b8bd to 5ae8810 Compare September 3, 2025 10:01
@tleon tleon changed the title Added a folder creation to avoid docker_run.sh from crashing Add missing extraction logic in nightly script Sep 3, 2025
@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Sep 3, 2025 •
edited
Loading

Thanks @tleon. Can you run the following command and commit the generated Dockerfiles?

./prestashop_docker.py generate

@tleon tleon force-pushed the fix-nightly-image-9.0.x_8.2 branch from 5ae8810 to 9ab0382 Compare September 3, 2025 12:15
@tleon tleon requested a review from Quetzacoalt91 September 3, 2025 12:20
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Sep 3, 2025
@Quetzacoalt91 Quetzacoalt91 merged commit 4d139c2 into PrestaShop:master Sep 3, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Merged in PR Dashboard Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

Assignees

@tleon tleon

Labels

None yet

Projects

PR Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tleon @Quetzacoalt91