Skip to content

Conversation

@boherm
Copy link
Member

@boherm boherm commented Dec 18, 2025

Questions Answers
Description? Add endpoint to duplicate a discount. (improvement of the api ADR: PrestaShop/ADR#43)
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#40281
Sponsor company PrestaShop SA
How to test? See PrestaShop/PrestaShop#40281

@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Dec 18, 2025
@boherm boherm force-pushed the duplicate-discount-endpoint branch from 583ce6b to 129cc6d Compare December 18, 2025 16:32
@ps-jarvis ps-jarvis moved this from Ready for review to Waiting for author in PR Dashboard Dec 18, 2025
@boherm boherm force-pushed the duplicate-discount-endpoint branch 3 times, most recently from 2739363 to b787f7d Compare December 18, 2025 17:49
@boherm boherm requested a review from nicosomb December 18, 2025 17:49
@boherm boherm force-pushed the duplicate-discount-endpoint branch from b787f7d to 09afdc7 Compare December 18, 2025 17:51
@boherm boherm moved this from Waiting for author to Ready for review in PR Dashboard Dec 18, 2025
@boherm boherm force-pushed the duplicate-discount-endpoint branch from 09afdc7 to 83cae67 Compare December 18, 2025 18:02
nicosomb
nicosomb previously approved these changes Dec 18, 2025
@boherm boherm force-pushed the duplicate-discount-endpoint branch 2 times, most recently from 0897392 to 633a7c3 Compare January 6, 2026 08:45
@boherm boherm force-pushed the duplicate-discount-endpoint branch from 633a7c3 to bac3e5f Compare January 6, 2026 08:57
@boherm boherm requested review from jolelievre and nicosomb January 6, 2026 08:58
@paulnoelcholot paulnoelcholot self-assigned this Jan 8, 2026
@paulnoelcholot
Copy link

Hello @boherm,

I tested you PR and it's good for me! 🎉

Thanks!

Test 1 :
image

Test 2 :
image

Test 3 :
image

Test 4 :
image

Test 5:
image

The changes have been successfully implemented on the back office.

@paulnoelcholot paulnoelcholot added the QA ✔️ Status: QA-Approved label Jan 14, 2026
@paulnoelcholot paulnoelcholot moved this from Ready for review to To be merged in PR Dashboard Jan 14, 2026
@boherm
Copy link
Member Author

boherm commented Jan 14, 2026

Thanks @paulnoelcholot!

@boherm boherm merged commit 3a50fa1 into PrestaShop:dev Jan 14, 2026
21 checks passed
@github-project-automation github-project-automation bot moved this from To be merged to Merged in PR Dashboard Jan 14, 2026
@boherm boherm deleted the duplicate-discount-endpoint branch January 14, 2026 16:06
@ps-jarvis ps-jarvis moved this from Merged to To be merged in PR Dashboard Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA ✔️ Status: QA-Approved

Projects

Status: To be merged

Development

Successfully merging this pull request may close these issues.

Duplicate one discount (return the new discount created)

5 participants