Bulk enable disable delete discount #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mattgoud
commented
Dec 19, 2025
mattgoud
commented
| Questions | Answers |
|---|---|
| Description? | add bulk operations for discounts (status and delation) |
| Type? | new feature |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #40282 |
| Sponsor company | @PrestaShopCorp |
| How to test? | see #40282 |
…mprove doc for bulk delete
jolelievre
reviewed
Dec 19, 2025
…te import for bulk-update-status
…meter (422 instead of 400)
|
Hello @mattgoud! This is your first pull request on ps_apiresources repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
jolelievre
reviewed
Dec 22, 2025
Comment on lines
518
to
522
| $bearerToken = $this->getBearerToken(['discount_read']); | ||
| static::createClient()->request('GET', '/discounts/' . $discountId, [ | ||
| 'auth_bearer' => $bearerToken, | ||
| ]); | ||
| self::assertResponseStatusCodeSame(404); |
Contributor
There was a problem hiding this comment.
You can replace this with the getItem method, the third parameter allows you to specify the expected HTTP code (here 404)
| $validId = $discount['discountId']; | ||
|
|
||
| // Try to bulk enable with mixed valid and invalid IDs | ||
| $bearerToken = $this->getBearerToken(['discount_write']); |
Contributor
There was a problem hiding this comment.
Similarily here (and following tests) you can also use the partialUpdateItem method and provide the expected HTTP error code
…y needs to send an empty JSON object to test
Contributor
Author
|
NB: @jolelievre we can't use bulkDeleteItems method for testBulkDeleteWithMissingParameter caused we need to pass an empty json for this edge case without generating a 400 error (see DiscountEndpointTest - lines 568-577 ) |
nicosomb
approved these changes
Dec 29, 2025
jolelievre
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.