-
Notifications
You must be signed in to change notification settings - Fork 25
Add resource for Discount Type #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
jolelievre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things to fix, and the test class in the core's PR should be moved in this module and we're good
|
Ah, and for your next PRs prefer using your fork please |
oops, sorry |
381bdcb to
23587c8
Compare
23587c8 to
5d4052c
Compare
|
|
||
| $this->assertGreaterThanOrEqual(1, count($discountTypes)); | ||
|
|
||
| if (count($discountTypes) > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to use explicit asertEquals with complete data (to make sure all fields are present, and no field in missing in the expected data Not necessarily all the types but at least the first one
GET http://myshop/admin-api/discount-typesshould return a json with discount types (see below)Example of json response