Skip to content

Conversation

@Progi1984
Copy link
Member

@Progi1984 Progi1984 commented Oct 28, 2025

Questions Answers
Branch? dev
Description? Added endpoints for domain "WebserviceKey" (Delete & BulkDelete)
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? ⬇️
Fixed issue or discussion? N/A
Related PRs PrestaShop/PrestaShop/pull/39748
Sponsor company lefevre.dev

How to test ?

  • Create 3 webservice keys in backoffice and keep their IDs {idWSK1} {idWSK2} {idWSK3}
  • Create an API Client with these scopes : webservice_key_write
  • Query 1 :
    • Method : DELETE
    • URI : /webservice-key/{idWSK1}
    • Response :
      • HTTP Code : 204
  • Check in the BO : the WS Key idWSK1 is not found (it is deleted)
  • Query 2 :
    • Method : PUT
    • URI : /webservice-keys/delete
    • Body :
    {"webserviceKeyIds": [{idWSK2}, {idWSK3}]}
    • Response :
      • HTTP Code : 204
  • Check in the BO : WS Keys idWSK2 & idWSK3 are not found (they are deleted)

@Progi1984 Progi1984 force-pushed the webservice branch 2 times, most recently from 5be528f to f357018 Compare October 29, 2025 07:18
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Oct 30, 2025
@Progi1984 Progi1984 marked this pull request as ready for review November 4, 2025 15:59
@Progi1984 Progi1984 requested a review from a team November 4, 2025 16:02
boherm
boherm previously approved these changes Nov 5, 2025
@boherm boherm added the Waiting for QA Status: Waiting for QA feedback label Nov 5, 2025
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Nov 5, 2025
@SiraDIOP SiraDIOP self-assigned this Nov 5, 2025
@SiraDIOP SiraDIOP removed the Waiting for QA Status: Waiting for QA feedback label Nov 7, 2025
@SiraDIOP SiraDIOP assigned Progi1984 and unassigned SiraDIOP Nov 7, 2025
@ps-jarvis ps-jarvis moved this from To be tested to Waiting for author in PR Dashboard Nov 13, 2025
@Progi1984 Progi1984 added Waiting for QA Status: Waiting for QA feedback and removed Waiting for author labels Nov 13, 2025
@ps-jarvis ps-jarvis moved this from Waiting for author to To be tested in PR Dashboard Nov 13, 2025
@SiraDIOP SiraDIOP self-assigned this Nov 14, 2025
@paulnoelcholot paulnoelcholot self-assigned this Nov 21, 2025
Copy link

@paulnoelcholot paulnoelcholot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Progi1984,

I tested your PR and I found somes bugs :/

PR-2025-11-21_11.39.37.mp4
PR-2025-11-21_11.40.58.mp4

@ps-jarvis ps-jarvis moved this from To be tested to Waiting for author in PR Dashboard Nov 21, 2025
@Progi1984 Progi1984 marked this pull request as draft November 25, 2025 08:10
@kpodemski
Copy link
Contributor

Hello @Progi1984

Is this still supposed to be a draft?

@Progi1984
Copy link
Member Author

Affirmative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Waiting for author

Development

Successfully merging this pull request may close these issues.

5 participants