Conversation
|
requesting a review from these two, but ofc anyone is welcome to review this |
|
ok should be actually ready now! |
1e2a86d to
a0bde95
Compare
jonbarrow
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for knocking this out 👍 just one small comment
In the future I wonder if it would be better to use something like https://jsx.email for emails rather than trying to hand-roll it ourselves, but that's a topic for a future day. This is definitely a big improvement over what we had before
That's a good point, though to be honest idk how helpful that would be now that I've implemented this. But yeah, probably good to talk about that in a decade or so, when email clients will support html from the 2010s. probably. |
743ba49 to
17b294e
Compare
|
I guess @mrjvs if this looks good to you or will then it can be merged? |
|
nodemailer? i hardly know 'er! (yeah i can do that) |
in case @mrjvs reads this: jon is gonna test this himself with the actual config we use on the website. this pr should be ready to review whenever, for real this time. |
Resolves #297
Changes:
Rewrote the email generation code to be easier to use and a lot more flexible. Also slightly edited the email styles.
Constructing and sending an email is as easy as this: