Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - Continued from PretendoNetwork/grpc#3 and PretendoNetwork/account#188
Changes:
Juxt has been having issues lately with users able to access the first-time account setup page incorrectly. The idea is that these pages are only viewable on a genuine console, and therefore only users with linked devices can complete account setup and use Juxt - this is a key anti-spam policy. Unfortunately, any number of bugs in Juxt or the account server can accidentally show this page incorrectly, and once an account completes setup, there's no way to detect the problem.
This PR will, in coordination with account server changes, have Juxt directly check the linked devices on user accounts. This will provide much better resilience to this whole process, allow us to open up account setup on web, allow enforcement of console bans on web (currently only account bans are enforced), etc.