Skip to content

Conversation

@samsja
Copy link
Member

@samsja samsja commented Jan 21, 2026

Make reload_weights on training from scratch configurable to allow skipping base weight reload.


Open in Cursor Open in Web


Note

Introduces configurability for resetting inference weights when starting from scratch.

  • Adds orchestrator.reload_weights_on_start (default: True) to OrchestratorConfig with descriptive docs
  • Updates orchestrator.py start-up: if no checkpoint, conditionally reload_weights only when the flag is enabled; always skip base reload when model.lora is set
  • Documents the new field in CHANGELOG.md

Written by Cursor Bugbot for commit ef0da2e. This will update automatically on new commits. Configure here.

@cursor
Copy link

cursor bot commented Jan 21, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@samsja samsja marked this pull request as ready for review January 21, 2026 21:20
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@samsja
Copy link
Member Author

samsja commented Jan 22, 2026

@cursoragent can u make it true byt defaut to avoid issue

@cursor
Copy link

cursor bot commented Jan 22, 2026

Done. Default is now True, plus changelog entry.

Open in Cursor Open in Web

@samsja samsja merged commit d0f2eb4 into main Jan 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants