`impl::compute_coupling` tests #1537

int-ptr-ptr · 2026-01-06T16:53:33Z

Description

Please describe the changes/features in this pull request.

Issue Number

If there is an issue created for these changes, link it here

#1258

Checklist

Please make sure to check developer documentation on specfem docs.

I ran the code through pre-commit to check style
THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
I have added labels to the PR (see right hand side of the PR page)
My code passes all the integration tests
I have added sufficient unittests to test my changes
I have added/updated documentation for the changes I am proposing
I have updated CMakeLists to ensure my code builds
My code builds across all platforms

Rohit-Kakodkar · 2026-01-13T12:26:21Z

tests/unit-tests/compute_coupling/nonconforming/nonconforming.hpp

+        for (int ielem = 0; ielem < virtual_chunk_size; ++ielem) {
+          for (int ipoint = 0; ipoint < TransferFunction2D::nquad_intersection;
+               ++ipoint) {
+            for (int icomp = 0; icomp < ncomp_self; ++icomp) {
+              computed_coupling_function(iedge_start + ielem, ipoint, icomp) =
+                  CCF(ielem, ipoint, icomp);
+            }
+          }
+        }


What's happening here. Shouldn't passing the subbview already store it in computed_coupling_function. Are you doing a = a; here ?

Rohit-Kakodkar · 2026-01-13T12:27:18Z

tests/unit-tests/compute_coupling/nonconforming/nonconforming.hpp

+  typename decltype(
+      computed_coupling_function)::HostMirror h_computed_coupling_function =
+      Kokkos::create_mirror_view(computed_coupling_function);
+
+  Kokkos::deep_copy(h_computed_coupling_function, computed_coupling_function);


Suggested change

typename decltype(

computed_coupling_function)::HostMirror h_computed_coupling_function =

Kokkos::create_mirror_view(computed_coupling_function);

Kokkos::deep_copy(h_computed_coupling_function, computed_coupling_function);

const auto h_computed_coupling_function = Kokkos::create_mirror_view_and_copy(computed_coupling_function);

Rohit-Kakodkar · 2026-01-13T12:27:33Z

tests/unit-tests/compute_coupling/nonconforming/nonconforming.hpp

+    for (int ipoint = 0; ipoint < TransferFunction2D::nquad_intersection;
+         ++ipoint) {
+      for (int icomp = 0; icomp < ncomp_self; ++icomp) {
+        const type_real got = computed_coupling_function(ielem, ipoint, icomp);


Suggested change

const type_real got = computed_coupling_function(ielem, ipoint, icomp);

const type_real got = h_computed_coupling_function(ielem, ipoint, icomp);

Rohit-Kakodkar · 2026-01-13T12:30:50Z

tests/unit-tests/utilities/include/fixture/nonconforming_interface/analytical_function.hpp

+/**
+ * @brief Concatenates k functions into an array-valued function.
+ *
+ */
+template <typename... AnalyticalFunctions>
+struct Vectorized : AnalyticalFunctionType {


This needs more description

Rohit-Kakodkar · 2026-01-13T12:31:44Z

tests/unit-tests/utilities/include/fixture/nonconforming_interface/analytical_function.hpp

+/**
+ * @brief Sums k functions.
+ *
+ */
+template <typename... AnalyticalFunctions> struct Sum : AnalyticalFunctionType {


lsawade

I think this should be reworked into a parameterized test. It seems overengineered. TransferFunctionTestTypes2D_AcousticElastic_Natural could just be a set of parameters from a map that initialize whatever needs to be tested. But maybe I'm missing something.

lsawade

See PR

Updated the tests create single tests that call a templated run function.

int-ptr-ptr · 2026-01-18T21:21:22Z

Note

I changed the base to issue-1554 for a better git diff.

Rohit-Kakodkar · 2026-01-22T14:19:34Z

tests/unit-tests/compute_coupling/nonconforming/nonconforming.hpp

+        // for (int ielem = 0; ielem < virtual_chunk_size; ++ielem) {
+        //   for (int ipoint = 0; ipoint <
+        //   TransferFunction2D::nquad_intersection;
+        //        ++ipoint) {
+        //     for (int icomp = 0; icomp < ncomp_self; ++icomp) {
+        //       computed_coupling_function(iedge_start + ielem, ipoint, icomp)
+        //       =
+        //           CCF(ielem, ipoint, icomp);
+        //     }
+        //   }
+        // }


Suggested change

// for (int ielem = 0; ielem < virtual_chunk_size; ++ielem) {

// for (int ipoint = 0; ipoint <

// TransferFunction2D::nquad_intersection;

// ++ipoint) {

// for (int icomp = 0; icomp < ncomp_self; ++icomp) {

// computed_coupling_function(iedge_start + ielem, ipoint, icomp)

// =

// CCF(ielem, ipoint, icomp);

// }

// }

// }

Rohit-Kakodkar

Minor changes.

Rohit-Kakodkar · 2026-01-22T14:49:15Z

tests/unit-tests/compute_coupling/nonconforming/nonconforming.hpp

+  specfem::test_fixture::IntersectionFunction2D<ExpectedSolutionInit>
+      expected_solution{ ExpectedSolutionInit{} };


This will not be generalizable. For example, a case where we manually compute the expected solution for a simplied transfer/intersection function, you'd have to write another runner. I would suggest creating a compute_expected_solution function and write a specialization that calls this initializer, when you know the solution analytically.

I'm not sure what you mean, here. IntersectionFunction2D is the array itself. The compute_expected_solution is embedded within the initializer, which gives the 3D array of type_real.

I am not sure what you mean by compute_expected_solution is embedded within the initializer. What would happen if the expected solution init is not a function of type analytical function?

I would have thought that in a general case you'd compute the expected solution using a serial loop, similar to how we do it in the gradient test.

See PR int-ptr-ptr#5

I'm not sure why the intersection function is needed. The purpose of adding the mock classes was to supply input for the functions under test. The intersection function seems to be attempting to mock the return type. Am I overlooking something?

IntersectionFunction is an input type for the coupling integrals (and normal vector).

Ah okay, Thanks!

Review comment suggestions from Rohit

int-ptr-ptr added 4 commits December 30, 2025 21:49

completed draft of intersection_data

bb2742a

function concat

6045b92

Merge branch 'accessor-pack-fixture' into nci-compute_coupling

4de2644

completed test

a667cd1

int-ptr-ptr linked an issue Jan 6, 2026 that may be closed by this pull request

Add test for NCI compute_coupling #1258

Open

2 tasks

int-ptr-ptr requested review from Rohit-Kakodkar, icui and lsawade January 6, 2026 16:54

int-ptr-ptr added 4 commits January 7, 2026 03:23

changed name to fix unity build

9cf3fa4

Merge branch 'devel' into nci-compute_coupling

b2c0c85

update analytical function

dfcd808

reverted intersection_data removal

cc04450

Rohit-Kakodkar requested changes Jan 13, 2026

View reviewed changes

Rohit-Kakodkar added the tests label Jan 13, 2026

lsawade approved these changes Jan 13, 2026

View reviewed changes

lsawade added 3 commits January 13, 2026 16:10

Updated the tests to be parameterized.

63c0060

Removed the parameterized test to simplify structure

56391f0

Unified the run conforming test case

83d95e9

lsawade requested changes Jan 14, 2026

View reviewed changes

int-ptr-ptr and others added 5 commits January 14, 2026 14:57

Merge pull request #4 from PrincetonUniversity/nci-compute_coupling

612dd57

Updated the tests create single tests that call a templated run function.

Merge remote-tracking branch 'origin/devel' into nci-compute_coupling

deb405f

review changes, rename vectorized -> chain

b69bf34

Merge branch 'issue-1554' into nci-compute_coupling

699ed70

removed old nonconforming.cpp, removed snuck Kokkos includes

8a36f7b

int-ptr-ptr changed the base branch from devel to issue-1554 January 18, 2026 21:19

remove snuck Kokkos include

39f51c0

icui deleted the branch PrincetonUniversity:devel January 19, 2026 23:33

icui closed this Jan 19, 2026

int-ptr-ptr reopened this Jan 19, 2026

int-ptr-ptr changed the base branch from issue-1554 to devel January 19, 2026 23:39

int-ptr-ptr requested review from Rohit-Kakodkar and lsawade January 20, 2026 16:59

Rohit-Kakodkar reviewed Jan 22, 2026

View reviewed changes

Rohit-Kakodkar self-requested a review January 22, 2026 14:45

Rohit-Kakodkar requested changes Jan 22, 2026

View reviewed changes

Rohit-Kakodkar and others added 6 commits January 22, 2026 19:06

Review comment suggestions from Rohit

83feb7b

failing compilation

0a87004

Merge pull request #5 from Rohit-Kakodkar/PR-1537-review-comments

5e5b93e

Review comment suggestions from Rohit

resolved ncomp_self compilation error

1512d59

removed auto for gpu compile

ccc6ed8

change typename for gpu

1e4b0dc

int-ptr-ptr requested a review from Rohit-Kakodkar January 24, 2026 23:22

Rohit-Kakodkar approved these changes Jan 27, 2026

View reviewed changes

lsawade approved these changes Jan 27, 2026

View reviewed changes

icui approved these changes Jan 27, 2026

View reviewed changes

Rohit-Kakodkar merged commit e7e98b3 into PrincetonUniversity:devel Jan 27, 2026
8 checks passed

	const type_real got = computed_coupling_function(ielem, ipoint, icomp);
	const type_real got = h_computed_coupling_function(ielem, ipoint, icomp);

		specfem::test_fixture::IntersectionFunction2D<ExpectedSolutionInit>
		expected_solution{ ExpectedSolutionInit{} };

impl::compute_coupling tests #1537

impl::compute_coupling tests #1537

Uh oh!

Conversation

int-ptr-ptr commented Jan 6, 2026

Description

Issue Number

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lsawade left a comment

Choose a reason for hiding this comment

Uh oh!

lsawade left a comment

Choose a reason for hiding this comment

Uh oh!

int-ptr-ptr commented Jan 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rohit-Kakodkar Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

`impl::compute_coupling` tests #1537

`impl::compute_coupling` tests #1537

Rohit-Kakodkar Jan 23, 2026 •

edited

Loading