Skip to content

1554 - Move enumerations to core Part II#1635

Merged
icui merged 20 commits intodevelfrom
1554-enum2
Feb 6, 2026
Merged

1554 - Move enumerations to core Part II#1635
icui merged 20 commits intodevelfrom
1554-enum2

Conversation

@icui
Copy link
Collaborator

@icui icui commented Feb 4, 2026

Description

  • Rename namespace specfem::connections to specfem::element_connections
  • Rename namespace specfem::interface to specfem::element_coupling
  • Move 'specfem::wavefieldandspecfem::displaytospecfem::enums`

Issue Number

Closes #1554

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

Base automatically changed from 1554-enum to devel February 4, 2026 20:31
@icui icui changed the title [WIP] 1554 - Move enumerations to core Part II 1554 - Move enumerations to core Part II Feb 6, 2026
@icui icui marked this pull request as ready for review February 6, 2026 14:09
@icui icui requested a review from lsawade February 6, 2026 14:10
@icui icui added the refactor label Feb 6, 2026
Copy link
Collaborator

@lsawade lsawade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icui icui merged commit 2b3bbd3 into devel Feb 6, 2026
8 checks passed
@icui icui deleted the 1554-enum2 branch February 6, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants