Add support for CVA6 + HPDC #172
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's necessary to analyze the proper value of the FIFO
Collaborator
|
This patch is ultimately pretty small but the history is quite long - could you squash it down to a single commit? |
Contributor
Author
|
Yup, I was planning on doing that once everything was set and ready, e.g. in case I need to add some more commits to apply feedback or update ariane or whatever. If you consider it necessary I can do that right now. |
AnaBSF
reviewed
Nov 20, 2025
There was a problem hiding this comment.
L15_BYTE_MASK_WIDHT -> L15_BYTE_MASK_WIDTH
AnaBSF
reviewed
Nov 26, 2025
There was a problem hiding this comment.
I get this error (perl 5, version 26, subversion 1 (v5.26.1)): Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\${ <-- HERE ?(\w+)}?/ at piton/tools/src/sims/sims,2.0 line 1165
Shouldn't it be $line =~ s/\$\{?(\w+)\}?/$ENV{$1}/g ; ?
AnaBSF
reviewed
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds support for using the HPDC in OpenPiton. To do so, I have added and updated the L1.5 adapters and hpdcache cache subsystems.
Because previously the L1.5 interface types & enums were in the wt_cache pkg and adapter files, I have moved the typedefs to a l15_pkg in this repository. This allows any cache (and any core) to interface with the L1.5.
I have tested the changes and they're passing physical and virtual single core tests. I am running more tests but I thought I'd open the merge requests already to get any possible discussions out of the way earlier.
When openhwgroup/cva6#3134 is accepted I will change the submodule paths and this will be ready to be merged.
This merge requests also contains some misc. fixes by me to provide support for my testing environment, mainly verilator 5+, waveforms, multithreaded compilation of bootrom, newer riscv compiler fixes, etc...
CC: @Jbalkind