Introduce grammar patch from the simplify branch
#4019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2025
DmitrySharabin
force-pushed
the
grammar-patch
branch
from
765068a to
29284d8
Compare
DmitrySharabin
force-pushed
the
grammar-patch
branch
from
29284d8 to
35d6181
Compare
✅ Deploy Preview for dev-prismjs-com ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DmitrySharabin
force-pushed
the
grammar-patch
branch
2 times, most recently
from
538eaec to
3328581
Compare
Authored by: Lea Verou <[email protected]>
DmitrySharabin
force-pushed
the
grammar-patch
branch
from
3328581 to
f1faac8
Compare
DmitrySharabin
commented
Oct 13, 2025
| return source; | ||
| } | ||
|
|
||
| return source ?? target; |
Member
Author
There was a problem hiding this comment.
I updated this part to handle the $merge special property correctly. Before, it was target ?? source, and we couldn't merge numbers, strings, regexes, etc.
LeaVerou
reviewed
Oct 29, 2025
|
|
||
| /** @typedef {import('../../src/types.d.ts').GrammarOptions} GrammarOptions */ | ||
| /** | ||
| * @typedef {import('../../src/types.d.ts').GrammarOptions} GrammarOptions |
Member
There was a problem hiding this comment.
Btw this might be useful here too: color-js/color.js#685
Member
Author
There was a problem hiding this comment.
Yup, it's on my list. 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isObject(),isPlainObject(),deepMerge(),deepClone(),betterAssign(),insert(), andinsertAfter(). UpdateinsertBefore()accordingly.extend()to support new special properties ($insertBefore,$insertAfter,$insert,$delete, and$merge) that allow defining grammars more declaratively and adding a newgrammarPatch()util (all authored by @LeaVerou). See [v2] Language combinations / extensions / embeddings / ... #3927 for details.Those are non-breaking changes. Corresponding changes to language definitions are in a separate PR.
This is part 2 of 3 in a stack made with GitButler:
simplifybranch #4019 👈languagesfrom thesimplifybranch #4016