Cache sha1 file #76
Open
Cache sha1 file #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getchoo
reviewed
Dec 17, 2024
Member
getchoo
left a comment
getchoo
left a comment
There was a problem hiding this comment.
Diff LGTM
Would be nice to have some types assigned to these, though
Member
Author
Types to functions arguments? or to what exactly? |
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Member
I think getchoo means type annotation on the functions |
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Ryex
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #62
This just adds an extra sha1 file to not calculate it each time(I expect the file downloaded to not change until fully removed)