Fix outdated flatpak build instructions#794
Open
slonkazoid wants to merge 1 commit intoPrismLauncher:mainfrom
Open
Fix outdated flatpak build instructions#794slonkazoid wants to merge 1 commit intoPrismLauncher:mainfrom
slonkazoid wants to merge 1 commit intoPrismLauncher:mainfrom
Conversation
- you are supposed to use the `org.flatpak.Builder` flatpak to build other flatpaks. this is important for reproducibility and to avoid linking issues - you do NOT need external build deps to build a flatpak - the versions mentioned are completely off - you only need java 17 to build consider also adding `--force-build` to the flatpak builder cmdline Signed-off-by: slonkazoid <slonkazoid@slonk.ing>
✅ Deploy Preview for prismlauncher ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.flatpak.Builderflatpak to build other flatpaks. this is important for reproducibility and to avoid linking issuesconsider also adding
--force-buildto the flatpak builder cmdline