workflows: git diff returns 1 on diff opposed to error

Author: extremeheat

.github/commands/setupCopilot.js

@@ -23,7 +23,7 @@ const failOnError = process.env.FAIL_ON_ERROR === 'true'
 
 // Save some time by skipping old versions as we are not parallelizing builds
 const versions = require('../../versions.json')
-const SKIP_VERSIONS = versions.slice(0, versions.indexOf('1.21.3'))
+const SKIP_VERSIONS = versions.slice(0, -2) // all but last 2 versions
 
 async function main () {
 

.github/workflows/copilot-setup-steps.yml

@@ -67,5 +67,10 @@ jobs:
           ref: client${{ steps.sb.outputs.second_latest_version }}
           fetch-depth: 1
 
+      - run: ls mc-source
+
       - name: Write diff
-        run: cd mc-source && git diff --no-index ${{ steps.sb.outputs.second_latest_version }} ${{ steps.sb.outputs.latest_version }} > ${{ steps.sb.outputs.second_latest_version }}_to_${{ steps.sb.outputs.latest_version }}.diff
+        # NOTE: this returns exit code 1 if there are differences
+        run: git diff --no-index ${{ steps.sb.outputs.second_latest_version }} ${{ steps.sb.outputs.latest_version }} > ${{ steps.sb.outputs.second_latest_version }}_to_${{ steps.sb.outputs.latest_version }}.diff
+        working-directory: mc-source
+        continue-on-error: true