Fix 1.21.11 WaterAnimal incorrectly assumed removed#67
Merged
extremeheat merged 1 commit intoPrismarineJS:bumpfrom Feb 16, 2026
Merged
Fix 1.21.11 WaterAnimal incorrectly assumed removed#67extremeheat merged 1 commit intoPrismarineJS:bumpfrom
extremeheat merged 1 commit intoPrismarineJS:bumpfrom
Conversation
Member
|
Thanks for the catch |
extremeheat
added a commit
that referenced
this pull request
Feb 19, 2026
* Add version 1.21.11 * Fix 1.21.11 compilation errors from Minecraft API changes (#65) * Initial plan * Fix 1.21.11 compilation: Replace ResourceLocation with Identifier and update WaterAnimal/getSkyColor Co-authored-by: extremeheat <13713600+extremeheat@users.noreply.github.com> * Add type-safe instanceof check before casting sky color argument Co-authored-by: extremeheat <13713600+extremeheat@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: extremeheat <13713600+extremeheat@users.noreply.github.com> * Fix incorrect biome color representation (#66) * Fix water_creature entities no longer being classified correctly (#67) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: extremeheat <13713600+extremeheat@users.noreply.github.com> Co-authored-by: SuperGamerTron <45374546+SuperGamerTron@users.noreply.github.com> Co-authored-by: Paul Fulham <paul.fulham0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
WaterAnimalcheck inEntitiesDataGeneratorwas wrongly removed in #65, causing Cod, Pufferfish, Salmon, Tadpole, and Tropical Fish to no longer have the type of "water_creature".In 1.21.11,
WaterAnimalwas not removed, it was instead moved under a "fish" package.This PR restores the check, albeit the entity "type" property has debatable utility. Nonetheless, this addresses the 1.21.11 regression.