Improve Copilot instructions to detect renames/moves#69
Merged
extremeheat merged 1 commit intoPrismarineJS:mainfrom Feb 23, 2026
Merged
Improve Copilot instructions to detect renames/moves#69extremeheat merged 1 commit intoPrismarineJS:mainfrom
extremeheat merged 1 commit intoPrismarineJS:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopened #68 on main.
In #65, Copilot incorrectly assumed
WaterAnimalwas removed when it was actually just moved to a different package. To reduce potential repeats of this error this PR does the following:.github/workflows/copilot-setup-steps.ymlto usegit diff -M50% -l2000to enable rename detection.github/copilot-instructions.mdto:mc-source/is not just one set of sources, but multiple, and must be searched in accordinglyThis is an extension of my findings for the specific regression fix in #67
An example of this change is the WaterAnimal refactor would instead of being presented as an addition and a removal, which generally share no proximity in diffs, would now appear unified as: