Pc 1 21 9 fix spawn entity velocity

[richnetdesign]

No description provided.

[micahstubbs]

Hi @richnetdesign, thanks for working on 1.21.9 support.

I've been testing this branch and found an issue with entity_velocity packets causing PartialReadError warnings. The fix is straightforward in proto.yml (changing velocity: lpvec3 to data: restBuffer), but I ran into a challenge when trying to contribute it.

When I regenerate protocol.json from proto.yml using npm run build (or the protodef-yaml compile function), the output differs significantly from the protocol.json in this branch. For example:

• Packet ID mappings use decimal ("0": "set_protocol") instead of hex ("0x00": "set_protocol")
• Some type definitions differ (e.g., RespawnData structure, spawn_entity fields)

I noticed the commit message mentions "manual patches to json. need to investigate why not regenerated automatically" - have you found the root cause of why the build script output doesn't match?

I'd like to help sync proto.yml with protocol.json so that future fixes can be contributed properly. Is there something specific about the 1.21.9 protocol that requires manual edits, or is this a build tooling issue that needs to be resolved first?

[richnetdesign]

hi @micahstubbs you might be on better track than me because I am overly relying on AI and need to fix somethings it did in this branch. my main point was I think your fixes should be targeting 1.21.9 instead of 1.21.10. I just noticed you were working on same things as me and didn't want to step on each others toes. I had already merged some changes to 1.21.9 related to the place holders you had, so might make sense for you to move your PR to 1.21.9

[micahstubbs]

If you haven't already, you might try testing with a https://github.com/mindcraft-bots/mindcraft bot against a local 1.21.9 minecraft server / lan game. That seemed to help me spot some of the issues. My local mindcraft bot appears to be able to play 1.21.9 successfully with your diff in this PR. I think you are close. I'll post issues and/pr fixes here if I encounter them with more bot-playtesting.

[extremeheat]

Where is lpvec3 defined?

[extremeheat]

Done in #1096