Fix attribute_modifiers structure in protocol.json for 1.21.5-1.21.11#1155
Open
reallyoldfogie wants to merge 2 commits intoPrismarineJS:masterfrom
Open
Fix attribute_modifiers structure in protocol.json for 1.21.5-1.21.11#1155reallyoldfogie wants to merge 2 commits intoPrismarineJS:masterfrom
reallyoldfogie wants to merge 2 commits intoPrismarineJS:masterfrom
Conversation
The attribute_modifiers component was incorrectly structured as a container with "attributes" and "display" as sibling top-level fields. Based on an analysis of AttributeModifiersComponent in the affected versions, the correct structure is an array of entries where each entry contains typeId, name, value, operation, slot, and display fields inline (except 1.21.5, where display remains at the outer level). Affected versions: 1.21.5, 1.21.6, 1.21.8, 1.21.9, 1.21.11
The attribute_modifiers component was incorrectly structured as a container with "attributes" and "display" as sibling top-level fields. Based on an analysis of AttributeModifiersComponent in the affected versions, the correct structure is an array of entries where each entry contains typeId, name, value, operation, slot, and display fields inline (except 1.21.5, where display remains at the outer level). Affected versions: 1.21.5, 1.21.6, 1.21.8, 1.21.9, 1.21.11
extremeheat
reviewed
Mar 25, 2026
| - armor | ||
| - body | ||
| - saddle | ||
| showTooltip: bool |
Member
|
Are you sure this is necessary? Seems to me you are only unwrapping a field which should not affect serialization/deserialization beyond an extra container. There are changes between versions also, see comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribute_modifiers component was incorrectly structured as a container with "attributes" and "display" as sibling top-level fields. Based on an analysis of AttributeModifiersComponent in the affected versions, the correct structure is an array of entries where each entry contains typeId, name, value, operation, slot, and display fields inline (except 1.21.5, which doesn't have a display).
Affected versions: 1.21.5, 1.21.6, 1.21.8, 1.21.9, 1.21.11