Merged
Conversation
The race condition occurred when an unauthenticated user clicked the toolbar to open a dialog. The `pointerup` event would toggle the dialog open, but then bubble up to a document-level listener that would immediately close it. This fix calls `event.stopPropagation()` in the toolbar's `onPointerUp` handler to prevent the event from reaching the document listener, ensuring the dialog remains open as intended.
The race condition occurred when an unauthenticated user clicked the toolbar to open a dialog. The `pointerup` event would toggle the dialog open, but then bubble up to a document-level listener that would immediately close it. This fix calls `event.stopPropagation()` in the toolbar's `onPointerUp` handler to prevent the event from reaching the document listener, ensuring the dialog remains open as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.