Fix: Show inviter name on login modal for unauthenticated users#44
Merged
Fix: Show inviter name on login modal for unauthenticated users#44
Conversation
Refactored the `load` function and auth handling to ensure that when an invite link is opened by an unauthenticated user, the inviter's name is fetched and displayed on the login modal. Previously, friend data was only loaded if a user was authenticated, leading to a generic login modal even with an invite link. Changes: - `load` function in `src/index.tsx` now separates fetching friend details from loading match data. Friend details can be fetched even if the user is not authenticated. - `useEffect` for auth state changes in `src/index.tsx` now calls `load` appropriately to fetch friend details if a friend ID is present in the URL, regardless of auth state. - Confirmed `Login.tsx` correctly uses the `friendData` prop and the 'Decline Invitation' button behavior is appropriate with the refactored `load` logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the
loadfunction and auth handling to ensure that when an invite link is opened by an unauthenticated user, the inviter's name is fetched and displayed on the login modal.Previously, friend data was only loaded if a user was authenticated, leading to a generic login modal even with an invite link.
Changes:
loadfunction insrc/index.tsxnow separates fetching friend details from loading match data. Friend details can be fetched even if the user is not authenticated.useEffectfor auth state changes insrc/index.tsxnow callsloadappropriately to fetch friend details if a friend ID is present in the URL, regardless of auth state.Login.tsxcorrectly uses thefriendDataprop and the 'Decline Invitation' button behavior is appropriate with the refactoredloadlogic.