Skip to content

FOUR-23865: Fix loading tasks in saved search with process with html entities#8199

Merged
ryancooley merged 4 commits intodevelopfrom
bugfix/FOUR-23865
May 21, 2025
Merged

FOUR-23865: Fix loading tasks in saved search with process with html entities#8199
ryancooley merged 4 commits intodevelopfrom
bugfix/FOUR-23865

Conversation

@caleeli
Copy link
Contributor

@caleeli caleeli commented Apr 17, 2025

Error loading tasks in saved search with process with html entities

Solution

  • Add support to html entities in bpmn documents

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:nayra:bugfix/FOUR-23865
ci:deploy
ci:package-savedsearch:bugfix/FOUR-23865
ci:k8s-branch:task/FOUR-24126

....

@pmPaulis
Copy link
Contributor

@caleeli some tests are failing, Could you check please?

Process Html (Tests\Feature\ProcessHtml)
 ✘ Process with html can be loaded
   │
   │ ErrorException: file_get_contents(/opt/processmaker/tests/Fixtures/process_with_html.bpmn): Failed to open stream: No such file or directory
   │
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:256
   │ /opt/processmaker/tests/TestCase.php:169
   │ /opt/processmaker/tests/Feature/ProcessHtmlTest.php:26
   │
 ✘ Store process with html entities
   │
   │ ErrorException: file_get_contents(/opt/processmaker/tests/Fixtures/process_with_html.bpmn): Failed to open stream: No such file or directory
   │
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:256
   │ /opt/processmaker/tests/Feature/ProcessHtmlTest.php:45
   │
 ✘ Update process with html entities
   │
   │ ErrorException: file_get_contents(/opt/processmaker/tests/Fixtures/process_with_html.bpmn): Failed to open stream: No such file or directory
   │
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:256
   │ /opt/processmaker/tests/Feature/ProcessHtmlTest.php:75
   │
 ✘ Update bpmn endpoint with html entities
   │
   │ ErrorException: file_get_contents(/opt/processmaker/tests/Fixtures/process_with_html.bpmn): Failed to open stream: No such file or directory
   │
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php:256
   │ /opt/processmaker/tests/Feature/ProcessHtmlTest.php:115
   │

Regards,

@boliviacoca
Copy link
Contributor

Failing because of: https://processmaker.atlassian.net/browse/FOUR-24126

@pmPaulis
Copy link
Contributor

@pmPaulis
Copy link
Contributor

@caleeli
The changes looks good, it solve the issue related to the Server Error, but is important to know that currently the following issueerror is blocking to see the charts:

production.ERROR: Chart Rendering Error: :message. {"message":"Undefined array key \"ProcessMaker__id\""}

image

Regards,

@pmPaulis pmPaulis changed the title FOUR-23865 Fix loading tasks in saved search with process with html entities FOUR-23865: Fix loading tasks in saved search with process with html entities Apr 23, 2025
@caleeli
Copy link
Contributor Author

caleeli commented Apr 23, 2025

@pmPaulis did you get a trace in the processmaker log related to the error message you get?

@pmPaulis
Copy link
Contributor

@pmPaulis did you get a trace in the processmaker log related to the error message you get?

I send you more information in the slack

@vladyrichter
Copy link

QA server K8S was successfully deployed https://ci-5109642553.engk8s.processmaker.net

@pmPaulis
Copy link
Contributor

@caleeli
please let me know if you will solve the error related to {"message":"Undefined array key \"ProcessMaker__id\""}
Regards

@vladyrichter
Copy link

QA server K8S was successfully deployed https://ci-5109642553.engk8s.processmaker.net

@boliviacoca boliviacoca added RC1 and removed Beta1 labels May 20, 2025
@ryancooley ryancooley changed the base branch from release-2025-spring to develop May 21, 2025 08:33
@vladyrichter
Copy link

QA server K8S was successfully deployed https://ci-5109642553.engk8s.processmaker.net

@processmaker-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ryancooley ryancooley merged commit 9b8f017 into develop May 21, 2025
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants